Re: ethtool.h compile warning on c++

2016-10-17 Thread Ivan Vecera

Dne 14.10.2016 v 21:46 Ben Greear napsal(a):

I am getting warnings about sign missmatch.

Maybe make SPEED_UNKNOWN be ((__u32)(0x)) ?


The 0xU could be better.

Ivan


ethtool.h compile warning on c++

2016-10-14 Thread Ben Greear

I am getting warnings about sign missmatch.

Maybe make SPEED_UNKNOWN be ((__u32)(0x)) ?

from ethtool.h:

#define SPEED_UNKNOWN   -1

static inline int ethtool_validate_speed(__u32 speed)
{
return speed <= INT_MAX || speed == SPEED_UNKNOWN;
}

Thanks,
Ben

--
Ben Greear 
Candela Technologies Inc  http://www.candelatech.com