Re: [PATCH 0/2] Netfilter/IPVS fixes for net

2016-06-07 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 7 Jun 2016 00:38:15 +0200 > The following patchset contains two Netfilter/IPVS fixes for your net > tree, they are: > > 1) Fix missing alignment in next offset calculation for standard >targets, introduced in the previous merge

Re: [PATCH] netfilter/nflog: nflog-range does not truncate packets

2016-06-07 Thread Vishwanath Pai
On 06/06/2016 06:31 PM, Pablo Neira Ayuso wrote: > On Wed, Jun 01, 2016 at 08:23:54PM -0400, Vishwanath Pai wrote: >> netfilter/nflog: nflog-range does not truncate packets >> >> The --nflog-range parameter from userspace is ignored in the kernel and >> the entire packet is sent to the userspace.

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Paul E. McKenney
On Tue, Jun 07, 2016 at 07:48:53PM +0200, Peter Zijlstra wrote: > On Tue, Jun 07, 2016 at 08:23:15AM -0700, Paul E. McKenney wrote: > > and if the hardware is not excessively clever (bad bet, by the > > way, long term), > > This ^ > > > > Is there something else than conditional move

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Hannes Frederic Sowa
On 07.06.2016 17:23, Paul E. McKenney wrote: > On Tue, Jun 07, 2016 at 04:59:02PM +0200, Hannes Frederic Sowa wrote: >> On 07.06.2016 15:06, Paul E. McKenney wrote: >>> On Tue, Jun 07, 2016 at 02:41:44PM +0200, Hannes Frederic Sowa wrote: On 07.06.2016 09:15, Peter Zijlstra wrote: >>

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

2016-06-07 Thread Joe Perches
On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote: > On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote: > > One more question, is this chunk below correct from > > coding style point of view? > > if (info->bitmask & EBT_STP_ROOTADDR) { > verdict = 0; >   

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Peter Zijlstra
On Tue, Jun 07, 2016 at 08:23:15AM -0700, Paul E. McKenney wrote: > and if the hardware is not excessively clever (bad bet, by the > way, long term), This ^ > > Is there something else than conditional move instructions that could > > come to play here? Obviously a much smarter CPU could

Re: [PATCH -v4 5/7] locking, arch: Update spin_unlock_wait()

2016-06-07 Thread Peter Zijlstra
On Tue, Jun 07, 2016 at 08:45:53PM +0800, Boqun Feng wrote: > On Tue, Jun 07, 2016 at 02:00:16PM +0200, Peter Zijlstra wrote: > > On Tue, Jun 07, 2016 at 07:43:15PM +0800, Boqun Feng wrote: > > > On Mon, Jun 06, 2016 at 06:08:36PM +0200, Peter Zijlstra wrote: > > > > diff --git

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

2016-06-07 Thread Pablo Neira Ayuso
On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote: > On Tue, 2016-06-07 at 17:14 +0200, Pablo Neira Ayuso wrote: > > On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote: > > > From: Tobin C Harding > > > This is my second linux kernel patch. Unsure if I was meant to

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

2016-06-07 Thread Joe Perches
On Tue, 2016-06-07 at 17:14 +0200, Pablo Neira Ayuso wrote: > On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote: > > From: Tobin C Harding > > This is my second linux kernel patch. Unsure if I was meant to cc multiple > > mailing lists? [] > > diff --git

Re: [PATCH nf-next] netfilter: helper: avoid extra expectation iterations on unregister

2016-06-07 Thread Pablo Neira Ayuso
On Sun, May 15, 2016 at 07:50:14PM +0200, Florian Westphal wrote: > The expectation table is not duplicated per net namespace anymore, so we can > move > the expectation table and conntrack table iteration out of the per-net loop. Florian, I can place this in the nf-next tree. This hit the queue

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Paul E. McKenney
On Tue, Jun 07, 2016 at 04:59:02PM +0200, Hannes Frederic Sowa wrote: > On 07.06.2016 15:06, Paul E. McKenney wrote: > > On Tue, Jun 07, 2016 at 02:41:44PM +0200, Hannes Frederic Sowa wrote: > >> On 07.06.2016 09:15, Peter Zijlstra wrote: > > diff --git

Re: [PATCH 3/3] bridge: netfilter: checkpatch null comparison fixes

2016-06-07 Thread Pablo Neira Ayuso
On Tue, May 10, 2016 at 11:26:58AM +1000, tcharding wrote: > From: Tobin C Harding > > checkpatch produces comparison to null 'checks'. > > This patch amends them. We have quite a lot of these in the netfilter tree, so I'd rather start using prefered coding style from now on

Re: [PATCH 2/3] bridge: netfilter: checkpatch data type fixes

2016-06-07 Thread Pablo Neira Ayuso
On Tue, May 10, 2016 at 11:26:57AM +1000, tcharding wrote: > From: Tobin C Harding > > checkpatch produces data type 'checks'. > > This patch amends them by changing, for example: > uint8_t -> u8 This looks good. Applied, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH v2 libnftnl] Check all strdup

2016-06-07 Thread Pablo Neira Ayuso
Carlos, On Tue, May 31, 2016 at 12:08:32PM +0200, Carlos Falgueras García wrote: > Check all strdup possible error and treat it consequently. Please, manually apply these two patches in your local working copy: http://patchwork.ozlabs.org/patch/631659/ http://patchwork.ozlabs.org/patch/631660/

[PATCH libnftnl 2/2] src: get rid of EXPORT_SYMBOL_ALIAS()

2016-06-07 Thread Pablo Neira Ayuso
This machinery was introduced to avoid sudden compilation breakage of old nftables releases. With the release of 0.6 (and 0.5 which is now 9 months old) this is not required anymore. Moreover, users gain nothing from older releases since they are half-boiled and full of bugs. So let's get rid of

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Hannes Frederic Sowa
On 07.06.2016 15:06, Paul E. McKenney wrote: > On Tue, Jun 07, 2016 at 02:41:44PM +0200, Hannes Frederic Sowa wrote: >> On 07.06.2016 09:15, Peter Zijlstra wrote: diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Paul E. McKenney
On Tue, Jun 07, 2016 at 02:41:44PM +0200, Hannes Frederic Sowa wrote: > On 07.06.2016 09:15, Peter Zijlstra wrote: > >> > >> diff --git a/Documentation/memory-barriers.txt > >> b/Documentation/memory-barriers.txt > >> index 147ae8ec836f..a4d0a99de04d 100644 > >> ---

Re: [PATCH -v4 5/7] locking, arch: Update spin_unlock_wait()

2016-06-07 Thread Boqun Feng
On Tue, Jun 07, 2016 at 02:00:16PM +0200, Peter Zijlstra wrote: > On Tue, Jun 07, 2016 at 07:43:15PM +0800, Boqun Feng wrote: > > On Mon, Jun 06, 2016 at 06:08:36PM +0200, Peter Zijlstra wrote: > > > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > > > index

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Hannes Frederic Sowa
On 07.06.2016 09:15, Peter Zijlstra wrote: >> >> diff --git a/Documentation/memory-barriers.txt >> b/Documentation/memory-barriers.txt >> index 147ae8ec836f..a4d0a99de04d 100644 >> --- a/Documentation/memory-barriers.txt >> +++ b/Documentation/memory-barriers.txt >> @@ -806,6 +806,41 @@ out-guess

Re: [PATCH -v4 5/7] locking, arch: Update spin_unlock_wait()

2016-06-07 Thread Peter Zijlstra
On Tue, Jun 07, 2016 at 07:43:15PM +0800, Boqun Feng wrote: > On Mon, Jun 06, 2016 at 06:08:36PM +0200, Peter Zijlstra wrote: > > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > > index ce2f75e32ae1..e1c29d352e0e 100644 > > --- a/kernel/locking/qspinlock.c > > +++

Re: [PATCHv3] extensions: libip6t_frag: Add translation to nft

2016-06-07 Thread Pablo Neira Ayuso
On Tue, Jun 07, 2016 at 09:33:13AM +0200, Laura Garcia Liebana wrote: > diff --git a/extensions/libip6t_frag.c b/extensions/libip6t_frag.c > index 023df62..7871fb9 100644 > --- a/extensions/libip6t_frag.c > +++ b/extensions/libip6t_frag.c > @@ -173,6 +173,35 @@ static void frag_save(const void

[PATCHv3] extensions: libip6t_frag: Add translation to nft

2016-06-07 Thread Laura Garcia Liebana
Add translation for frag to nftables. According to the --fraglen code: case O_FRAGLEN: /* * As of Linux 3.0, the kernel does not check for * fraglen at all. */ In addition, the kernel code doesn't show any reference to

Re: [RFC][PATCH 1/3] locking: Introduce smp_acquire__after_ctrl_dep

2016-06-07 Thread Peter Zijlstra
On Mon, Jun 06, 2016 at 10:28:24AM -0700, Paul E. McKenney wrote: > commit 43672d15aeb69b1a196c06cbc071cbade8d247fd > Author: Paul E. McKenney > Date: Mon Jun 6 10:19:42 2016 -0700 > > documentation: Clarify limited control-dependency scope > > Nothing