On Wed, Oct 18, 2017 at 10:38:02AM +1100, Duncan Roe wrote:
> Hi Frank,
>
> The libnftnl patch was comitted 2 minutes before you posted :/
>
> It all builds fine for me now.
>
> Your problem is with generating the man page rather than with compiling the
> code. There is a separate Makefile in nf
Hi Frank,
The libnftnl patch was comitted 2 minutes before you posted :/
It all builds fine for me now.
Your problem is with generating the man page rather than with compiling the
code. There is a separate Makefile in nftables/doc which you can run on its
own to do this.
When I run "make V=1" i
Hi,
I trying to install nftables from source ask part of my Outreachy application
tasks. I already installed libmnl and libnftnl successfully.
The problem comes after the 'make' command while trying to compile nftables.
I'm running Ubuntu 16.04 and following the steps described here:
https://w
On Tue, Oct 17, 2017 at 03:48:13PM +0200, Eric Sesterhenn wrote:
> Hello Pablo,
>
> they fix different issues, therefore both should
> be applied.
OK, thanks for explaining. Let me get back to this asap.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of
Hello Pablo,
they fix different issues, therefore both should
be applied.
Regards,
Eric
On 17/10/17 15:09, Pablo Neira Ayuso wrote:
> Hi Eric,
>
> Is there any change with regards to previous patch?
>
> I have two in patchwork:
>
> http://patchwork.ozlabs.org/patch/823074/
> http://patchwork.
On Wed, Oct 04, 2017 at 11:41:11PM +0200, Phil Sutter wrote:
> This gets rid of the temporary buffer.
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/
On Tue, Oct 17, 2017 at 03:17:41PM +0200, Phil Sutter wrote:
> Implement expression printing into a FILE pointer analogous to
> nftnl_rule_fprintf().
Applied, thanks Phil!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kerne
Implement expression printing into a FILE pointer analogous to
nftnl_rule_fprintf().
Signed-off-by: Phil Sutter
---
Changes since v2:
- Fix src/libnftnl.map update.
Changes since v1:
- Update src/libnftnl.map.
---
include/libnftnl/expr.h | 1 +
src/expr.c | 14 ++
src/
Hi Eric,
Is there any change with regards to previous patch?
I have two in patchwork:
http://patchwork.ozlabs.org/patch/823074/
http://patchwork.ozlabs.org/patch/825682/
Which one should I consider for submission?
Thanks!
On Fri, Oct 13, 2017 at 08:29:08PM +0200, Eric Sesterhenn wrote:
>
> F
On Sat, Oct 14, 2017 at 06:21:45PM +0530, Harsha Sharma wrote:
> configure.ac checks for libnfnetlink(>=1.0) library
>
> Signed-off-by: Harsha Sharma
> ---
> INSTALL | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/INSTALL b/INSTALL
> index d62b428c..d28ea5c1 100644
> --- a/INSTALL
> ++
On Tue, Oct 17, 2017 at 02:44:21PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Oct 17, 2017 at 06:11:20PM +0530, Harsha Sharma wrote:
> > On Tue, Oct 17, 2017 at 4:57 PM, Pablo Neira Ayuso
> > wrote:
> > > On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
> > >> Print tests passed with
On Tue, Oct 17, 2017 at 06:11:20PM +0530, Harsha Sharma wrote:
> On Tue, Oct 17, 2017 at 4:57 PM, Pablo Neira Ayuso
> wrote:
> > On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
> >> Print tests passed with errors and warnings when run with only specified
> >> test file.
> >
> > I w
On Tue, Oct 17, 2017 at 4:57 PM, Pablo Neira Ayuso wrote:
> On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
>> Print tests passed with errors and warnings when run with only specified
>> test file.
>
> I would expect this works like this, for consistency with other test
> infrastruc
On Tue, Oct 17, 2017 at 05:59:37PM +0530, Harsha Sharma wrote:
> This patch checks that the iptables TOS to nftables translation works fine.
Applied, thanks Harsha.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
M
On Tue, Oct 17, 2017 at 02:32:39PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Oct 13, 2017 at 10:35:24PM +0530, Harsha Sharma wrote:
> > Added comments and files generated by libtools
>
> Applied, thanks.
>
> Please, add the right tag next time, eg. [PATCH iptables] So I know
> the route for this
On Fri, Oct 13, 2017 at 10:35:24PM +0530, Harsha Sharma wrote:
> Added comments and files generated by libtools
Applied, thanks.
Please, add the right tag next time, eg. [PATCH iptables] So I know
the route for this at quick glance.
Thanks!
--
To unsubscribe from this list: send the line "unsubs
This patch checks that the iptables TOS to nftables translation works fine.
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Change subject and log message
extensions/libxt_TOS.txlate | 25 +
1 file changed, 25 insertions(+)
create mode 100644 extensions/libxt_TOS.txla
On Mon, Oct 09, 2017 at 03:47:39PM +0200, Phil Sutter wrote:
> Previously, an MSS range of e.g. 65535:1000 was silently accepted but
> would then never match a packet since the kernel checks whether the MSS
> value is greater than or equal to the first *and* less than or equal to
> the second value
On Tue, Oct 17, 2017 at 02:02:22PM +0200, Phil Sutter wrote:
> Hi,
>
> Actually, I don't quite get the suggested change:
>
> On Tue, Oct 17, 2017 at 01:31:50PM +0200, Pablo Neira Ayuso wrote:
> > @@ -308,3 +307,7 @@ global:
> >
> > local: *;
> > };
> > +
> > +LIBNFTNL_6 {
> > + nftnl_expr_fp
On Thu, Oct 12, 2017 at 06:24:11PM +1100, Duncan Roe wrote:
> A Google search for "Native Address Translation" found 1 entry
> (http://encyclopedia2.thefreedictionary.com/Native+address+translation) which
> redirects to .../Network+address+translation. All other matches are to entries
> about "Netw
On Sat, Oct 14, 2017 at 04:16:03PM +0530, Harsha Sharma wrote:
> Add testcases for creating named limits and referencing them
> from rule
Applied, thanks Harsha.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More
From: Colin Ian King
The assignment to variable e is redundant since the same assignment
occurs just a few lines later, hence it can be removed. Cleans up
clang warning: warning: Value stored to 'e' is never read
Signed-off-by: Colin Ian King
---
net/ipv6/netfilter/ip6_tables.c | 1 -
1 file
Hi,
Actually, I don't quite get the suggested change:
On Tue, Oct 17, 2017 at 01:31:50PM +0200, Pablo Neira Ayuso wrote:
> @@ -308,3 +307,7 @@ global:
>
> local: *;
> };
> +
> +LIBNFTNL_6 {
> + nftnl_expr_fprintf;
> +} LIBMNL_5;
Why LIBMNL_5? Shouldn't this be LIBNFTNL_5?
Cheers, Phil
--
T
On Tue, Oct 17, 2017 at 01:56:28PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Oct 17, 2017 at 02:32:09AM +0530, Aastha Gupta wrote:
> > This adds test file for the recently added TCPMSS extension.
>
> I'm taking this last version, it doesn't say v4 but looking at timing,
> it is the last one you ha
On Sun, Oct 15, 2017 at 05:32:19PM +0530, Aastha Gupta wrote:
> Since path mtu support was added, we can now add
> iptables-compat translation for TCPMSS extension.
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@
On Tue, Oct 17, 2017 at 02:32:09AM +0530, Aastha Gupta wrote:
> This adds test file for the recently added TCPMSS extension.
I'm taking this last version, it doesn't say v4 but looking at timing,
it is the last one you have submitted.
Applied, thanks. If there is anything you need to fix, send me
On Tue, Oct 17, 2017 at 01:31:50PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Oct 17, 2017 at 01:22:18PM +0200, Phil Sutter wrote:
> > Implement expression printing into a FILE pointer analogous to
> > nftnl_rule_fprintf().
> >
> > Signed-off-by: Phil Sutter
> > ---
> > Changes since v1:
> > - Upd
On Tue, Oct 17, 2017 at 01:02:18AM +0530, Harsha Sharma wrote:
> This test suite is intended to detect regressions in the translation
> infrastructure. The script checks if ip[6]tables-translate produces the
> expected output, otherwise it prints the wrong translation and the
> expected one.
>
> *
On Tue, Oct 17, 2017 at 01:22:18PM +0200, Phil Sutter wrote:
> Implement expression printing into a FILE pointer analogous to
> nftnl_rule_fprintf().
>
> Signed-off-by: Phil Sutter
> ---
> Changes since v1:
> - Update src/libnftnl.map
Thanks Phil.
I think we need to collapse this change to your
On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
> Print tests passed with errors and warnings when run with only specified
> test file.
I would expect this works like this, for consistency with other test
infrastructure we have:
# python xlate-test.py extensions/libxt_ecn.txlate
E
Implement expression printing into a FILE pointer analogous to
nftnl_rule_fprintf().
Signed-off-by: Phil Sutter
---
Changes since v1:
- Update src/libnftnl.map
---
include/libnftnl/expr.h | 1 +
src/expr.c | 14 ++
src/libnftnl.map| 1 +
3 files changed, 16 ins
On Sat, Oct 14, 2017 at 06:34:28PM +0530, Varsha Rao wrote:
> Hello Pablo,
>
> On Wed, Oct 11, 2017 at 3:27 PM, Pablo Neira Ayuso
> wrote:
> > Hi Varsha,
> >
> > On Wed, Oct 11, 2017 at 10:03:56AM +0530, Varsha Rao wrote:
> >> Test files of tests/files/ are moved to tests/shell.
> >
> > We have
Hi Phil,
On Wed, Oct 04, 2017 at 11:36:40PM +0200, Phil Sutter wrote:
> Implement expression printing into a FILE pointer analogous to
> nftnl_rule_fprintf().
src/libnftnl.map needs to be updated. I can do it here myself, no
problem, or feel free to send v2, as you prefer.
> Signed-off-by: Phil
Expressions with EXPR_F_INTERVAL_END flag set on have no right hand side,
so they store no stateful object. Skip them so we don't crash on this.
# nft add map x testmap { type inet_service: counter\; flags interval\;}
# nft add counter x testcounter
# nft add element x testmap { 0-100 : "testco
Print tests passed with errors and warnings when run with only specified
test file.
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Change subject
-print the errors if no argument is passed
xlate-test.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xlate-test.py b/
Print tests passed with errors and warnings when run with only specified
test file.
Signed-off-by: Harsha Sharma
---
xlate-test.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xlate-test.py b/xlate-test.py
index 43c4be19..b7a053f9 100755
--- a/xlate-test.py
+++ b/xlate
36 matches
Mail list logo
