Re: [PATCH] ebtables: Fix build errors and warnings

On Tue, May 15, 2018 at 12:42:09AM +0200, Florian Westphal wrote: > Duncan Roe wrote: > > Since commit b1cdae87f25021eb835872d86d6e7206bd421c3f, make fails thusly: > > > > > libebtc.c: In function 'ebt_reinit_extensions': > > > libebtc.c:275:11: error: 'union ' has no

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Mon, May 21, 2018 at 12:40:54AM +0300, Or Gerlitz wrote: > On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner > wrote: > > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: > >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner > >>

[PATCH xtables] ebtables-compat: add arp extension

no translation yet, might be doable with raw payload expressions though. Signed-off-by: Florian Westphal --- extensions/libebt_arp.c | 490 iptables/xtables-eb.c | 1 + 2 files changed, 491 insertions(+) create mode 100644

[PATCH xtables] ebtables-compat: add redirect match extension

No translation. The kernel match will alter packet type (meta set pkttype), but also replace dst mac with the bridges' mac address, however nft currently doesn't allow to retrieve this at runtime. So just add this without the xlate part for now. Signed-off-by: Florian Westphal

[PATCH xtables] ebtables-compat: add nat match extensions

adds snat and dnat. Translation for snat isn't complete, the --snat-arp switch isn't supported so far. Signed-off-by: Florian Westphal --- extensions/libebt_dnat.c | 134 ++ extensions/libebt_dnat.txlate | 8 ++ extensions/libebt_snat.c

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner >> wrote: >> > On Mon, May 14, 2018 at 05:27:14PM

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: > On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner > wrote: > > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: > >> Substitute calls to action insert function with calls to action insert >

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> Substitute calls to action insert function with calls to action insert >> unique function that warns if insertion overwrites index in idr. >

Re: [PATCH 09/14] net: sched: don't release reference on action overwrite

On Sat 19 May 2018 at 21:52, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote: >> Return from action init function with reference to action taken, >> even when overwriting existing action. > > Isn't this patch necessary

[PATCH net-next v1] netfilter: provide input interface for route lookup for rpfilter

In commit 47b7e7f82802, this bit was removed at the same time the RT6_LOOKUP_F_IFACE flag was removed. However, it is needed when link-local addresses are used, which is a very common case: when packets are routed, neighbor solicitations are done using link-local addresses. For example, the

Re: [PATCH 06/14] net: sched: implement reference counted action release

On Sun 20 May 2018 at 06:22, Jiri Pirko wrote: > Sat, May 19, 2018 at 11:43:27PM CEST, marcelo.leit...@gmail.com wrote: >>On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote: >>... >>> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct >>>

Re: [PATCH 02/14] net: sched: change type of reference and bind counters

On Sat 19 May 2018 at 21:04, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:03PM +0300, Vlad Buslov wrote: >> Change type of action reference counter to refcount_t. >> >> Change type of action bind counter to atomic_t. >> This type is used to allow

Re: [PATCH nf-next,v3 3/3] netfilter: nfnetlink_queue: resolve clash for unconfirmed conntracks

Hi Pablo, I love your patch! Yet something to improve: [auto build test ERROR on nf-next/master] [also build test ERROR on v4.17-rc5] [cannot apply to nf/master next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 06/14] net: sched: implement reference counted action release

Sat, May 19, 2018 at 11:43:27PM CEST, marcelo.leit...@gmail.com wrote: >On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote: >... >> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct >> nlattr *nla, >> return err; >> } >> >> +static int