[PATCH nft] tests: shell: validate too deep jumpstack from basechain

2018-08-08 Thread Pablo Neira Ayuso
If there is no basechain, the validation is never exercised. Too deep nested chains are fine as long as they are not connected to a basechain. Update test to add a basechain so we exercise validation. Signed-off-by: Pablo Neira Ayuso --- I'm dropping this patch:

Re: [PATCH v2] nft: doc: changes in configure file for PDF creation

2018-08-08 Thread Pablo Neira Ayuso
On Wed, Aug 08, 2018 at 02:34:37AM +0530, Arushi Singhal wrote: > changes in package dependencies for PDF creation (nft.pdf) from > asciidoc. If I apply this patch, I can hit the following error: make[2]: Entering directory '/home/git/nftables/doc' a2x --doctype manpage --format manpage -D .

Re: [PATCH] nft: doc: Fixed all the typos in asciidoc

2018-08-08 Thread Pablo Neira Ayuso
Hi Arushi, On Wed, Aug 08, 2018 at 11:00:36AM +0530, Arushi Singhal wrote: > Correct all the typo mistakes done while converting man page source to > asciidoc. Patch doesn't apply with git am. Please, run: git pull --rebase origin master before submitting patches, to make sure you

Re: [PATCH nf-next] netfilter: nfnetlink_osf: add missing enum in nfnetlink_osf uapi header

2018-08-08 Thread Pablo Neira Ayuso
I have included the following description, please moving forward add descriptions to your patches: -o- xt_osf_window_size_options was originally part of include/uapi/linux/netfilter/xt_osf.h, restore it. Fixes: bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from

Re: [PATCH] nft: doc: Fixed all the typos in asciidoc

2018-08-08 Thread Máté Eckl
On Wed, Aug 08, 2018 at 03:18:18PM +0530, Arushi Singhal wrote: > Hello > > On Wed, Aug 8, 2018 at 12:12 PM, Máté Eckl wrote: > > > On Wed, Aug 08, 2018 at 11:00:36AM +0530, Arushi Singhal wrote: > > > Correct all the typo mistakes done while converting man page source to > > > asciidoc. > > >

Re: [PATCH] nft: doc: Fixed all the typos in asciidoc

2018-08-08 Thread Máté Eckl
On Wed, Aug 08, 2018 at 11:00:36AM +0530, Arushi Singhal wrote: > Correct all the typo mistakes done while converting man page source to > asciidoc. Hi, I made only two comments. See below. > > Signed-off-by: Arushi Singhal > --- > doc/data-types.txt | 2 +- > doc/nft.txt

Re: [PATCH] nft: doc: fix make distcheck

2018-08-08 Thread Máté Eckl
On Wed, Aug 08, 2018 at 10:49:26AM +0530, Arushi Singhal wrote: > fix make distcheck for conversion to asciidoc. > > Signed-off-by: Arushi Singhal > --- > doc/Makefile.am | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/Makefile.am b/doc/Makefile.am > index