Re: [PATCH nft] src: remove opts field from struct xt_stmt

2018-10-16 Thread Phil Sutter
On Tue, Oct 16, 2018 at 08:58:20PM +0200, Pablo Neira Ayuso wrote: > This is never used, ie. always NULL. > > Reported-by: Phil Sutter > Signed-off-by: Pablo Neira Ayuso Acked-by: Phil Sutter Thanks for clearing this up!

[PATCH nft] src: remove opts field from struct xt_stmt

2018-10-16 Thread Pablo Neira Ayuso
This is never used, ie. always NULL. Reported-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- include/statement.h | 1 - src/statement.c | 1 - src/xt.c| 8 ++-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/include/statement.h b/include/statement.h

[PATCH nf-next] netfilter: xt_quota: simplify quota logic, account for consumed bytes

2018-10-16 Thread Pablo Neira Ayuso
Store consumed bytes, instead of remaining bytes, this simplifies logic quite a bit. Cc: Chenbo Feng Cc: Maciej Żenczykowski Signed-off-by: Pablo Neira Ayuso --- Before merge window closes and it's too late to change semantics. include/uapi/linux/netfilter/xt_quota.h | 4 ++--

[nf-next:master 1/7] net/ipv4/netfilter/ipt_ECN.c:58:28: error: 'IPT_ECN_OP_SET_ECE' undeclared; did you mean 'IPT_ECN_OP_MATCH_ECE'?

2018-10-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master head: 60dd57bba519ab75277df610d5d245ed3af3c57c commit: 25038aaf0cbf7639a18f80aeddb325811aff23c3 [1/7] UAPI: netfilter: Fix symbol collision issues [ver #2] config: m68k-mvme16x_defconfig (attached as .config)