Re: [PATCH nft] configure.ac: docbook2man invalid syntax error

rapper and has a different syntax so the command fails. > > Maybe if you point out the bug, I can look after it. A possible solution is to update configure.ac to check that docbook2man (if found) accept the correct option. BR, -- Eric > > Regards, > Máté > > On Mon

[PATCH nft] tests/py: fix import when run from other directory

Signed-off-by: Eric Leblond --- tests/py/nft-test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index 1c736be..e4367ad 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -19,11 +19,11 @@ import argparse import

[PATCH nft v2 3/7] configure.ac: docbook2man invalid syntax error

docbook2man can not be used with the same option so let's remove it from the alternative. Fedora and debian seems to be fine with that. --- configure.ac | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 4d21cb4..9f5d0f9 100644 ---

[PATCH nft v2 1/7] configure.ac: better message when a2x is missing

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3c5ba4d..5705702 100644 --- a/configure.ac +++ b/configure.ac @@ -82,7 +82,7 @@ AM_COND_IF([BUILD_PDF], [ AS_IF([test "$need_a2x" = "yes"], [ AC_CHECK_PROG(A2X, [a2x],

[PATCH nft v2 5/7] python: set license and author in nftables.py

It will be distributed separately so this worth setting things correctly. --- py/nftables.py | 16 1 file changed, 16 insertions(+) diff --git a/py/nftables.py b/py/nftables.py index d613505..e725c56 100644 --- a/py/nftables.py +++ b/py/nftables.py @@ -1,3 +1,19 @@

[PATCH nft v2 6/7] doc: fix make distcheck

--- doc/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 9796d34..1ec3b3e 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -9,19 +9,19 @@ endif pdfdir=${docdir}/pdf .xml.pdf: - ${AM_V_GEN}dblatex -q -t

[PATCH nft v2 2/7] configure.ac: remove useless braces in messages

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5705702..4d21cb4 100644 --- a/configure.ac +++ b/configure.ac @@ -108,7 +108,7 @@ AC_SUBST(with_cli) AM_CONDITIONAL([BUILD_CLI], [test "x$with_cli" != xno])

[PATCH nft v2 4/7] python: installation of binding via make install

setup.py is used to build and install the python binding. Call to setup.py are done in Makefile to proceed to build and installation. --- Makefile.am| 3 ++- configure.ac | 24 py/.gitignore | 4 py/Makefile.am | 31 +++

[PATCH nft v2 7/7] tests/py: minor cleaning

Move import and use explicit parameter in object creation. --- tests/py/nft-test.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index c02294a..fdc1cd5 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -19,6

[PATCH nft v2 0/7] python install and build fixes

Hello, Here is the update of previous patchset with improvement on python detection. It is now possible to specify which python binary to use at configure time. Following discussion with Phil Sutter, a version check is remaining. I will try to send that soon. BR, -- Eric Leblond

Re: [PATCH nft 3/8] python: installation of binding via make install

Hi, On Mon, 2018-06-18 at 13:51 +0200, Eric Leblond wrote: > setup.py is used to build and install the python binding. Call > to setup.py are done in Makefile to proceed to build and > installation. > --- > Makefile.am| 3 ++- ... > + 'Intended Audi

[PATCH nft 0/8] python install and build fixes

Hello, Here is a small patchset providing installation of the nftables python binding and fixing a series of small issues (biggest one is the fix of distcheck). Best Regards, -- Eric Leblond -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" i

[PATCH nft 3/8] python: installation of binding via make install

setup.py is used to build and install the python binding. Call to setup.py are done in Makefile to proceed to build and installation. --- Makefile.am| 3 ++- configure.ac | 6 ++ py/Makefile.am | 31 +++ py/__init__.py | 1 + py/nftables.py | 2 ++

[PATCH nft 8/8] doc: fix make distcheck

--- doc/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 9796d34..1ec3b3e 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -9,19 +9,19 @@ endif pdfdir=${docdir}/pdf .xml.pdf: - ${AM_V_GEN}dblatex -q -t

[PATCH nft 4/8] python: set license and author in nftables.py

It will be distributed separately so this worth setting things correctly. --- py/nftables.py | 16 1 file changed, 16 insertions(+) diff --git a/py/nftables.py b/py/nftables.py index d613505..e725c56 100644 --- a/py/nftables.py +++ b/py/nftables.py @@ -1,3 +1,19 @@

[PATCH nft 7/8] tests/py: minor cleaning

Move import and use explicit parameter in object creation. --- tests/py/nft-test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index c02294a..cbdff98 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -18,6

[PATCH nft 1/8] configure.ac: better message when a2x is missing

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3c5ba4d..5705702 100644 --- a/configure.ac +++ b/configure.ac @@ -82,7 +82,7 @@ AM_COND_IF([BUILD_PDF], [ AS_IF([test "$need_a2x" = "yes"], [ AC_CHECK_PROG(A2X, [a2x],

[PATCH nft 2/8] configure.ac: remove useless braces in messages

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 5705702..4d21cb4 100644 --- a/configure.ac +++ b/configure.ac @@ -108,7 +108,7 @@ AC_SUBST(with_cli) AM_CONDITIONAL([BUILD_CLI], [test "x$with_cli" != xno])

[PATCH nft 5/8] python: add build system file to .gitignore

--- py/.gitignore | 4 1 file changed, 4 insertions(+) diff --git a/py/.gitignore b/py/.gitignore index 0d20b64..09c1e62 100644 --- a/py/.gitignore +++ b/py/.gitignore @@ -1 +1,5 @@ *.pyc +build/ +dist/ +lib.*/ +nftables.egg-info/ -- 2.17.1 -- To unsubscribe from this list: send the line

[PATCH nft 6/8] python: change author info

Following discussion with Phil Sutter, set author to Netfilter project and use coreteam mail. --- py/setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/setup.py b/py/setup.py index 663574a..4154560 100755 --- a/py/setup.py +++ b/py/setup.py @@ -5,8 +5,8 @@ from

Re: [nft PATCH v2 2/2] src: get rid of printf

Hi, On Mon, 2017-09-04 at 22:53 +0200, Pablo Neira Ayuso wrote: > On Mon, Sep 04, 2017 at 10:43:48PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Sep 04, 2017 at 09:55:58AM +0200, Eric Leblond wrote: > > > This patch introduces the nft_print function that has to be used >

[nft PATCH v2 2/2] src: get rid of printf

the libnftables library to provide an easy way to the users to get the output data and display them like they want. Signed-off-by: Eric Leblond <e...@regit.org> --- include/datatype.h | 5 +- include/expression.h | 2 +- include/nftables.h | 5 ++ src/cli.c| 1 + sr

[nft PATCH v2 1/2] src: add flags fo nft_ctx_new

By adding flags to nft_ctx_new, we will have a minimum capabilities of changing the way the nft_ctx is created. For now, this patch uses a simple value that allow the user to specify that he will handle netlink by himself. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.

[nft PATCH v2] libnftables preparation work

Hi, This patchset update previous one following Pablo's suggestion: * remove unused custom netlink flag * rename ouput function to nft_print * change default output buffer size to 4k instead of 128 that was used for debug (and causing a lot of realloc) BR, -- Eric -- To unsubscribe from this

Re: [nft PATCH 2/2] src: get rid of printf

Hi, On Mon, 2017-09-04 at 00:34 +0200, Pablo Neira Ayuso wrote: > On Mon, Sep 04, 2017 at 12:03:56AM +0200, Eric Leblond wrote: > > This patch introduces the nft_print_to_output_ctx function that has > > to be used instead of printf to output information that where > > prev

Re: [nft PATCH 1/2] src: add flags fo nft_ctx_new

Hi, On Mon, 2017-09-04 at 00:45 +0200, Pablo Neira Ayuso wrote: > On Mon, Sep 04, 2017 at 12:33:09AM +0200, Pablo Neira Ayuso wrote: > > On Mon, Sep 04, 2017 at 12:03:55AM +0200, Eric Leblond wrote: > > > By adding flags to nft_ctx_new, we will have a minimum > > > cap

[nft PATCH 1/2] src: add flags fo nft_ctx_new

By adding flags to nft_ctx_new, we will have a minimum capabilities of changing the way the nft_ctx is created. For now, this patch uses a simple value that allow the user to specify that he will handle netlink by himself. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.

[nft PATCH 0/2] libnftables preparation work

Hi, Here is two patches relative to libnftables preparation work. The first one it changing the way a nft_ctx is created to be able to skip the netlink init function call and also to have some freedom later. The second one is getting the printf out. This is completely changed from what was

[nft PATCH 2/2] src: get rid of printf

will allow the libnftables library to provide an easy way to the users to get the output data and display them like they want. Signed-off-by: Eric Leblond <e...@regit.org> --- include/datatype.h | 5 +- include/expression.h | 2 +- include/nftables.h | 5 ++ src/cli.c

Re: [PATH nft v2 13/18] libnftables: add nft_context_set_print

Hi, On Fri, 2017-08-25 at 11:59 +0200, Pablo Neira Ayuso wrote: > On Sat, Aug 19, 2017 at 05:24:15PM +0200, Eric Leblond wrote: > > This function allows user to set his own printing function. It is > > still dependant of the format used by nft but at least it can be > &

Re: [PATH nft v2 15/18] libnftables: set max_errors to 1 in library

Hi, On Thu, 2017-08-24 at 18:02 +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 21, 2017 at 09:12:49PM +0200, Eric Leblond wrote: > [...] > > On Mon, 2017-08-21 at 10:37 +0200, Pablo Neira Ayuso wrote: > > [...] > > > > diff --git a/src/libnftables.c b/src/libnf

Re: [PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer

y way I find to do this is to - yick - add a flag to > nft_ctx_new(). Agree with the flag idea. This will add a minimum flexibility to the structure creation. Regarding the patch, I'm good with it. Acked-by: Eric Leblond <e...@regit.org> ++ -- Eric Leblond <e...@regit.org> -- To unsubscr

Re: [PATH nft v2 04/18] libnftables: add context new and free

as "don't handle netlink" or "handle netlink". But setting the info could also be done in another function so I let you decide. ++ > Thanks. > > > On Sat, Aug 19, 2017 at 05:24:06PM +0200, Eric Leblond wrote: > > Signed-off-by: Eric Leblond <e...@regit.

Re: [PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer

Hi, On Tue, 2017-08-22 at 14:37 +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 21, 2017 at 09:21:06PM +0200, Eric Leblond wrote: > > On Mon, 2017-08-21 at 11:44 +0200, Pablo Neira Ayuso wrote: > > > On Mon, Aug 21, 2017 at 11:06:19AM +0200, Eric Leblond wrote: > > [...]

Re: [PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer

Hi, On Mon, 2017-08-21 at 11:44 +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 21, 2017 at 11:06:19AM +0200, Eric Leblond wrote: > > Hi, > > > > On Mon, 2017-08-21 at 10:45 +0200, Pablo Neira Ayuso wrote: > > > On Mon, Aug 21, 2017 at 10:23:44AM +0200,

Re: [PATH nft v2 15/18] libnftables: set max_errors to 1 in library

Hi, On Mon, 2017-08-21 at 10:37 +0200, Pablo Neira Ayuso wrote: > On Sat, Aug 19, 2017 at 05:24:17PM +0200, Eric Leblond wrote: > > As memory handling is defficient if we don't do so, we can't really > > use a non 1 value for the parameter in the library due to memory > >

Re: [PATH nft v2 08/18] libnftables: add missing variables to library

Hello, On Mon, 2017-08-21 at 10:27 +0200, Pablo Neira Ayuso wrote: > On Sat, Aug 19, 2017 at 05:24:10PM +0200, Eric Leblond wrote: > > This patch also avoids double definition of global vars. > > > > Signed-off-by: Eric Leblond <e...@regit.org> > > --- >

Re: [PATH nft v2 01/18] mnl: fix error handling in mnl_batch_talk

Hi, On Mon, 2017-08-21 at 10:10 +0200, Pablo Neira Ayuso wrote: > Hi Eric, > > On Sat, Aug 19, 2017 at 05:24:03PM +0200, Eric Leblond wrote: > > If one of the command is failing we should return an error. > > Is this fixing up a real issue or it is something you need in

Re: [PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer

Hi, On Mon, 2017-08-21 at 10:45 +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 21, 2017 at 10:23:44AM +0200, Pablo Neira Ayuso wrote: > > On Sat, Aug 19, 2017 at 05:24:07PM +0200, Eric Leblond wrote: > > > Signed-off-by: Eric Leblond <e...@regit.org> > > > --- &

[PATH nft v2 15/18] libnftables: set max_errors to 1 in library

that can be used to modify the max_errors parameter. It is used in main to keep the existing behavior. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 1 + src/libnftables.c | 8 +++- src/main.c | 1 + 3 files changed, 9 insertions

[PATH nft v2 13/18] libnftables: add nft_context_set_print

This function allows user to set his own printing function. It is still dependant of the format used by nft but at least it can be redirected easily. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 3 +++ src/libnftables.c | 9 + 2 files c

[PATH nft v2 11/18] libnftables: move iface_cache_release to deinit

Signed-off-by: Eric Leblond <e...@regit.org> --- src/libnftables.c | 1 + src/main.c| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnftables.c b/src/libnftables.c index 19d539c..2228156 100644 --- a/src/libnftables.c +++ b/src/libnftables.c @@ -50,6

[PATH nft v2 10/18] libnftables: add a nft_cache to nft_ctx

Hide this structure from the user, this allows simplify the simple functions by just providing easy and meaningfull arguments. Signed-off-by: Eric Leblond <e...@regit.org> --- include/cli.h | 2 +- include/nftables.h | 13 +++-- include/nftables/nftables.

[PATH nft v2 16/18] libnftables: add error handling

It had a nft_get_error to be able to fetch existing errors and get them into a buffer that can be later used by the application. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h | 1 + include/nftables/nftables.h | 1 + src/libnftables.c

[PATH nft v2 12/18] libnftables: get rid of printf

Use a custom print function that user will be able to set instead of using a direct call to printf. Signed-off-by: Eric Leblond <e...@regit.org> --- include/datatype.h | 5 +- include/expression.h | 2 +- include/nftables.h | 2 + src/ct.c | 20 +++ src/data

[PATH nft v2 18/18] libnftables: doxygen documentation

Document libnftables and provide a Doxyfile example. Signed-off-by: Eric Leblond <e...@regit.org> --- Doxyfile | 2495 + src/libnftables.c | 211 - 2 files changed, 2705 insertions(+), 1 deletion(-) create mode 100644 Do

[PATH nft v2 17/18] libnftables: suppress unused global variables

Signed-off-by: Eric Leblond <e...@regit.org> --- src/libnftables.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/libnftables.c b/src/libnftables.c index b1df916..1abe077 100644 --- a/src/libnftables.c +++ b/src/libnftables.c @@ -26,9 +26,6 @@ unsigned int max_erro

[PATH nft v2 04/18] libnftables: add context new and free

Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h | 1 + include/nftables/nftables.h | 3 +++ src/libnftables.c | 20 src/main.c | 29 ++--- 4 files changed, 38 insertions(+), 15 del

[PATH nft v2 03/18] libnftables: introduce library

Add global init and deinit functions. Signed-off-by: Eric Leblond <e...@regit.org> --- configure.ac | 4 include/Makefile.am | 2 +- include/nftables/Makefile.am | 2 ++ include/nftables/nftables.h | 20 + src/Makefile.am

[PATCH nft v2 00/18] introducing libnftables

Hello, This patchset is the second version of libnftables introduction patchset. It addresses some remarks by Phil Sutter. Other remarks as said on the ML are in fact TODO points that can be adressed later. This patchset also fixes issues with error handling and adds documentation in doxygen

[PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer

Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 3 +++ src/libnftables.c | 26 +- src/main.c | 19 --- 3 files changed, 36 insertions(+), 12 deletions(-) diff --git a/include/nftables/nftabl

[PATH nft v2 07/18] libnftables: put nft_run in library

Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h| 4 -- include/nftables_common.h | 18 src/Makefile.am | 1 + src/cli.c | 1 + src/libnftables.c | 2 + src/main.c

[PATH nft v2 06/18] libnftables: add nft_run_command_from_filename

Add new function to read nftables command from a file Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 2 ++ src/libnftables.c | 25 + src/main.c | 16 +++- 3 files changed, 30 insertions(

[PATH nft v2 02/18] erec: add function to free list

Signed-off-by: Eric Leblond <e...@regit.org> --- include/erec.h | 1 + src/erec.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/erec.h b/include/erec.h index 36e0efa..befc274 100644 --- a/include/erec.h +++ b/include/erec.h @@ -60,6 +60,7 @@ static inlin

Re: [nft PATH 06/16] libnftables: add missing variable to library

Hi, On Thu, 2017-08-17 at 11:35 +0200, Phil Sutter wrote: > On Wed, Aug 16, 2017 at 10:43:00PM +0200, Eric Leblond wrote: > > Signed-off-by: Eric Leblond <e...@regit.org> > > --- > >  src/libnftables.c | 2 ++ > >  src/main.c| 1 - > >  2 fil

Re: [nft PATH 15/16] libnftables: add error handling

Hi, On Thu, 2017-08-17 at 12:32 +0200, Phil Sutter wrote: > On Wed, Aug 16, 2017 at 10:43:09PM +0200, Eric Leblond wrote: > [...] > > diff --git a/src/libnftables.c b/src/libnftables.c > > index c50c068..a42e8f1 100644 > > --- a/src/libnftables.c > > +++ b/src/li

Re: [nft PATH 10/16] libnftables: get rid of printf

Hi, On Thu, 2017-08-17 at 12:01 +0200, Phil Sutter wrote: > On Wed, Aug 16, 2017 at 10:43:04PM +0200, Eric Leblond wrote: > [...] > > diff --git a/include/nftables.h b/include/nftables.h > > index 348fbb0..ddff5d8 100644 > > --- a/include/nftables.h > > +++ b/include

Re: [nft PATH 01/16] libnftables: introduce library

Hi, On Thu, 2017-08-17 at 19:13 +0200, Phil Sutter wrote: > Hey, > > On Thu, Aug 17, 2017 at 07:09:02PM +0200, Eric Leblond wrote: > > On Thu, 2017-08-17 at 10:57 +0200, Phil Sutter wrote: > > > On Wed, Aug 16, 2017 at 10:42:55PM +0200, Eric Leblond wrote:

Re: [nft PATH 01/16] libnftables: introduce library

Hi, On Thu, 2017-08-17 at 10:57 +0200, Phil Sutter wrote: > On Wed, Aug 16, 2017 at 10:42:55PM +0200, Eric Leblond wrote: > [...] > > diff --git a/src/libnftables.c b/src/libnftables.c > > new file mode 100644 > > index 000..215179a > > --- /dev/null > >

Re: [nft PATCH 0/16] introduce libnftables

Hi, On Thu, 2017-08-17 at 10:32 +0200, Arturo Borrero Gonzalez wrote: > On 16 August 2017 at 22:42, Eric Leblond <e...@regit.org> wrote: > > > > Hello, > > > > This patchset adds a basi high level libnftables to nftables code. > > It is currently sup

[nft PATH 06/16] libnftables: add missing variable to library

Signed-off-by: Eric Leblond <e...@regit.org> --- src/libnftables.c | 2 ++ src/main.c| 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libnftables.c b/src/libnftables.c index 6599248..6d4aceb 100644 --- a/src/libnftables.c +++ b/src/libnftables.c @@ -33,6

[nft PATH 12/16] libnftables: transaction support

Signed-off-by: Eric Leblond <e...@regit.org> --- include/netlink.h | 5 +++ include/nftables/nftables.h | 7 src/libnftables.c | 89 + 3 files changed, 101 insertions(+) diff --git a/include/netlink.h b/include/net

[nft PATH 10/16] libnftables: get rid of printf

Use a custom print function that user will be able to set instead of using a direct call to printf. Signed-off-by: Eric Leblond <e...@regit.org> --- include/datatype.h | 5 +- include/expression.h | 2 +- include/nftables.h | 2 + src/ct.c | 20 +++ src/data

[nft PATH 01/16] libnftables: introduce library

Add global init and deinit functions. Signed-off-by: Eric Leblond <e...@regit.org> --- configure.ac | 4 include/Makefile.am | 2 +- include/nftables/Makefile.am | 2 ++ include/nftables/nftables.h | 20 + src/Makefile.am

[nft PATCH 0/16] introduce libnftables

Hello, This patchset adds a basi high level libnftables to nftables code. It is currently supporting running a command from a buffer or from a file as well as batch support allowing to chain commands and commit them at once. The API is mostly using existing structures such as nft_ctx that are

[nft PATH 07/16] libnftables: add NFT_EXIT_* to library

So it can be used by client to check function return. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h | 7 --- include/nftables/nftables.h | 7 +++ src/netlink.c | 1 + src/utils.c | 1 + 4 files changed, 9 insertions

[nft PATH 08/16] libnftables: add a nft_cache to nft_ctx

Hide this structure from the user, this allows simplify the simple functions by just providing easy and meaningfull arguments. Signed-off-by: Eric Leblond <e...@regit.org> --- include/cli.h | 2 +- include/nftables.h | 13 +++-- include/nftables/nftables.

[nft PATH 13/16] libnftables: set max_errors to 1 in library

that can be used to modify the max_errors parameter. It is used in main to keep the existing behavior. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 1 + src/libnftables.c | 8 +++- src/main.c | 1 + 3 files changed, 9 insertions

[nft PATH 09/16] libnftables: move iface_cache_release to deinit

Signed-off-by: Eric Leblond <e...@regit.org> --- src/libnftables.c | 1 + src/main.c| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnftables.c b/src/libnftables.c index 864156c..72e6efa 100644 --- a/src/libnftables.c +++ b/src/libnftables.c @@ -50,6

[nft PATH 03/16] libnftables: add nft_run_command_from_buffer

Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 3 +++ src/libnftables.c | 26 +- src/main.c | 21 + 3 files changed, 37 insertions(+), 13 deletions(-) diff --git a/include/nftables/nfta

[nft PATH 11/16] libnftables: add nft_context_set_print

This function allows user to set his own printing function. It is still dependant of the format used by nft but at least it can be redirected easily. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 3 +++ src/libnftables.c | 9 + 2 files c

[nft PATH 14/16] erec: add function to free list

Signed-off-by: Eric Leblond <e...@regit.org> --- include/erec.h | 1 + src/erec.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/erec.h b/include/erec.h index 36e0efa..befc274 100644 --- a/include/erec.h +++ b/include/erec.h @@ -60,6 +60,7 @@ static inlin

[nft PATH 04/16] libnftables: add nft_run_command_from_filename

Add new function to read nftables command from a file Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables/nftables.h | 2 ++ src/libnftables.c | 25 + src/main.c | 16 +++- 3 files changed, 30 insertions(

[nft PATH 05/16] libnftables: put nft_run in library

Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h| 4 -- include/nftables_common.h | 18 src/Makefile.am | 1 + src/cli.c | 1 + src/libnftables.c | 2 + src/main.c

[nft PATH 15/16] libnftables: add error handling

It had a nft_get_error to be able to fetch existing errors and get them into a buffer that can be later used by the application. Signed-off-by: Eric Leblond <e...@regit.org> --- include/nftables.h | 1 + include/nftables/nftables.h | 1 + src/libnftables.c

[nft PATH 16/16] libnftables: basic doxygen documentation

Signed-off-by: Eric Leblond <e...@regit.org> --- src/libnftables.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/src/libnftables.c b/src/libnftables.c index a42e8f1..a9e54c4 100644 --- a/src/libnftables.c +++ b/src/libnftables.c @@

[nft PATCH 2/7] parser: fix memory leak in set creation

: AddressSanitizer: 13 byte(s) leaked in 1 allocation(s). Signed-off-by: Eric Leblond <e...@regit.org> --- src/parser_bison.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/parser_bison.y b/src/parser_bison.y index a8448e1..c505a04 100644 --- a/src/parser_bison.y +++ b/src/parser_b

[nft PATCH 3/7] parser: fix bison warnings

int cmd; ^ = 0 Signed-off-by: Eric Leblond <e...@regit.org> --- src/parser_bison.y | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/parser_bison.y b/src/parser_bison.y index c505a04..b898e1c 100644 --- a/src/parser_bison.y +++ b/src/parser_biso

[nft PATCH 0/7] some memory leak fixes

Hi, Here's a small patchset fixing some memory leaks in nftables. Most of them have been found using ASAN. There is still a problem in memory handling due to the max_errors system that stack errors to avoid an exit on first error. The consequence is that the bison parser is loosing track of its

[nft PATCH 6/7] scanner: free filename when destroying scanner

To be able to do so we duplicate the name in the indesc if it is set. Signed-off-by: Eric Leblond <e...@regit.org> --- src/erec.c| 5 + src/scanner.l | 11 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/erec.c b/src/erec.c index eacdd97..439add9

[nft PATCH 4/7] parser: error if needed at EOF

Signed-off-by: Eric Leblond <e...@regit.org> --- src/parser_bison.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/parser_bison.y b/src/parser_bison.y index b898e1c..85cf131 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -756,6 +756,8 @

[nft PATCH 5/7] evaluate: fix build with clang

Building with a recent clang was failing due to the following error: src/evaluate.c|450 col 45| error: initializer element is not constant ||static const unsigned int max_tcpoptlen = 15 * 4 * BITS_PER_BYTE - tcphdrlen; || ^~ Signed-off-by: Eric

[PATCH libnfntl] set: free user data

/git/netfilter/libnftnl/src/set.c:179 Signed-off-by: Eric Leblond <e...@regit.org> --- src/set.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/set.c b/src/set.c index cce5e63..1158e38 100644 --- a/src/set.c +++ b/src/set.c @@ -48,6 +48,8 @@ void nftnl_set_free(const struct nftnl_

Re: [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values

Hello, On Wed, 2017-04-12 at 14:40 +0300, Kaarle Ritvanen wrote: > On Tue, 7 Mar 2017, Eric Leblond wrote: > > > I really like the idea of getting an harmonized naming for the log > > files but I think we should do it reverse for values that are not > > commented in the

Re: [PATCH] netfilter: synproxy: fix conntrackd interaction

Hi, On Mon, 2017-05-15 at 19:55 +0200, Pablo Neira Ayuso wrote: > On Mon, May 15, 2017 at 07:49:18PM +0200, Eric Leblond wrote: > >    Hello, > >    Le 15 mai 2017 6:52 PM, Pablo Neira Ayuso <pa...@netfilter.org> > > a > >    écrit : > > > >      O

[PATCH] netfilter: synproxy: fix conntrackd interaction

node. Signed-off-by: Eric Leblond <e...@regit.org> --- net/netfilter/nf_conntrack_netlink.c | 4 1 file changed, 4 insertions(+) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index dcf561b5c97a..1a127677ffe1 100644 --- a/net/net

[PATCH] netfilter: synproxy: fix conntrackd interaction

This patch fixes the creation of connection tracking entry from netlink when synproxy is used. It was missing the addition of the synproxy extension. This was causing kernel crashes when a conntrack entry created by conntrackd was used after the switch of traffic from active node to the passive

Re: [PATCH] ulogd: add +1 char for null char

671: > ``` > memcpy(pi->id, pi_id, sizeof(pi->id)); > ``` Thanks in advance, -- Eric Leblond <e...@regit.org> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values

onfiguration. Most users won't have changed the values that are uncommented. So they will have on disk the log file with name defined in the configuration file. And they will benefit from a new logrotate file. Thus we should use the file name defined in the conf as value of the default file name in code. C

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

t; /var/log/ulogd.pcap { > +/var/log/ulogd*.log { >  missingok >  sharedscripts >  postrotate PS to Kaarle: resending because initial mail did not reach the ML. BR, -- Eric Leblond <e...@regit.org> Blog: https://home.regit.org/ -- To unsubscribe from this list: send the

Re: [PATCH] ulogd: fix cross compilation errors with mysql_config

bin /usr/local/mysql/bin > /opt/mysql/bin /opt/packages/mysql/bin >  do > - if test -x $d/mysql_config > + if test -x $d/mysql_config -a "$cross_compiling" = "no"; >   then >   AC_MSG_RESULT(found mysql_config in $d) >   MYSQL_INC=`$d/mysql_config --in

Re: [RFC] a software based on ulogd

gt; added comment: > >     based on ulogd which was almost entirely written by Harald Welte, >     with contributions from fellow hackers such as Pablo Neira Ayuso, >     Eric Leblond and Pierre Chifflier. > > to each source file. Would you tell me other things to reuse ulogd? >