[PATCHv5][PING] Hide private symbols in libnfnetlink

On Fri, May 4, 2018 at 9:12 AM, Yuri Gribov <tetra2...@gmail.com> wrote: > On Fri, May 4, 2018 at 1:23 AM, Jan Engelhardt <jeng...@inai.de> wrote: >> Another additional line will be needed, >> >> EXTRA_libnfnetlink_la_DEPENDENCIES = nfnl.version >&

Re: [PATCH][PING] Hide private symbols in libnfnetlink

On Fri, May 4, 2018 at 1:23 AM, Jan Engelhardt <jeng...@inai.de> wrote: > On Thursday 2018-05-03 17:03, Yuri Gribov wrote: > >>Hi all, >> >>Here's the updated version of the patch. >> >>diff --git a/src/Makefile.am b/src/Makefile.am >>index d0098cc

[PATCH][PING] Hide private symbols in libnfnetlink

Hi all, Here's the updated version of the patch. -Y 0001-Hide-private-symbols-v4.patch Description: Binary data

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

On Sat, Apr 28, 2018 at 8:45 AM, Jan Engelhardt <jeng...@inai.de> wrote: > > On Saturday 2018-04-28 00:29, Yuri Gribov wrote: >>--- a/Make_global.am >>+++ b/Make_global.am >>@@ -5,4 +5,4 @@ >> LIBVERSION=2:0:2 >> >> AM_CPPFLAGS = -I$(top_srcdir)/i

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

On Fri, Apr 27, 2018 at 11:23 PM, Yuri Gribov <tetra2...@gmail.com> wrote: > On Fri, Apr 27, 2018 at 9:10 PM, Florian Westphal <f...@strlen.de> wrote: >> It doesn't build for me: >> x86_64-pc-linux-gnu/bin/ld: cannot open linker script file ./nfnl.version: >>

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

On Fri, Apr 27, 2018 at 9:10 PM, Florian Westphal wrote: > It doesn't build for me: > x86_64-pc-linux-gnu/bin/ld: cannot open linker script file ./nfnl.version: No > such file or directory > > I need to move that file to src/. It turned out to be slightly more complicated

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

On Fri, Apr 27, 2018 at 8:37 PM, Florian Westphal <f...@strlen.de> wrote: > Yuri Gribov <tetra2...@gmail.com> wrote: >> Would something like this make sense for trunk? > Yes, I think its a good idea to hide them. Ah, great. Let me know if something should be fixed i

[RFC][PATCH] Hide private symbols in libnfnetlink

Hi all, I've recently tried applying -fvisibility=hidden to libnfnetlink (draft patch attached) and was able to remove several (supposedly private) symbols from library interface: nfnl_set_sequence_tracking nfnl_unset_sequence_tracking rtnl_close rtnl_dump_type rtnl_handler_register