Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

2017-12-18 Thread Pablo Neira Ayuso
On Mon, Dec 11, 2017 at 10:18:05AM +0100, Florian Westphal wrote: > Colin King wrote: > > From: Colin Ian King > > > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > > not need to be in global scope, so make it static. > > This bug was added in > commit b9679a9fd3a7d

Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

2017-12-11 Thread Florian Westphal
Colin King wrote: > From: Colin Ian King > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > not need to be in global scope, so make it static. This bug was added in commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28 netfilter: conntrack: l4 protocol trackers can be cons

[PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

2017-12-10 Thread Colin King
From: Colin Ian King The structure nf_conntrack_l4proto_gre4 is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'nf_conntrack_l4proto_gre4' was not declared. Should it be static? Signed-off-by: Colin Ian King --- net/netfilter/