Re: [PATCH] ulogd: add +1 char for null char

2017-03-22 Thread Alexandru Ardelean
On Wed, Mar 22, 2017 at 9:07 AM, Alexandru Ardelean wrote: > On Tue, Mar 21, 2017 at 10:54 PM, Eric Leblond wrote: >> Hello, >> >> Thanks for the report and the patch. I'm not sure of your >> implementation. Can you test with the patch to follow ? >> >> On Mon, 2017-03-20 at 10:31 +0200, Alexandr

Re: [PATCH] ulogd: add +1 char for null char

2017-03-22 Thread Alexandru Ardelean
On Tue, Mar 21, 2017 at 10:54 PM, Eric Leblond wrote: > Hello, > > Thanks for the report and the patch. I'm not sure of your > implementation. Can you test with the patch to follow ? > > On Mon, 2017-03-20 at 10:31 +0200, Alexandru Ardelean wrote: >> This is a bit zealous to fix like this, but it

Re: [PATCH] ulogd: add +1 char for null char

2017-03-21 Thread Eric Leblond
Hello, Thanks for the report and the patch. I'm not sure of your implementation. Can you test with the patch to follow ? On Mon, 2017-03-20 at 10:31 +0200, Alexandru Ardelean wrote: > This is a bit zealous to fix like this, but it seems to work. > > The crash was reproduced on ppc32, with GCC 5.

[PATCH] ulogd: add +1 char for null char

2017-03-20 Thread Alexandru Ardelean
This is a bit zealous to fix like this, but it seems to work. The crash was reproduced on ppc32, with GCC 5.4 & musl libc 1.1.16. And also on LEDE (mips_24kc and ARM): https://github.com/openwrt/packages/issues/4123 https://github.com/openwrt/packages/issues/4090 I personally saw it on ppc32. Th