Re: [PATCH 1/1] netfilter: ipset: Check IPSET_ATTR_ETHER netlink attribute length

2016-03-08 Thread Jozsef Kadlecsik
Hi Daniel, On Tue, 8 Mar 2016, Daniel Borkmann wrote: > On 03/08/2016 08:44 PM, Jozsef Kadlecsik wrote: > > Julia Lawall pointed out that IPSET_ATTR_ETHER netlink attribute length > > was not checked explicitly, just for the maximum possible size. Malicious > > netlink clients could send shorter

Re: [PATCH 1/1] netfilter: ipset: Check IPSET_ATTR_ETHER netlink attribute length

2016-03-08 Thread Daniel Borkmann
Hi Jozsef, On 03/08/2016 08:44 PM, Jozsef Kadlecsik wrote: Julia Lawall pointed out that IPSET_ATTR_ETHER netlink attribute length was not checked explicitly, just for the maximum possible size. Malicious netlink clients could send shorter attribute and thus resulting a kernel read after the buf

[PATCH 1/1] netfilter: ipset: Check IPSET_ATTR_ETHER netlink attribute length

2016-03-08 Thread Jozsef Kadlecsik
Julia Lawall pointed out that IPSET_ATTR_ETHER netlink attribute length was not checked explicitly, just for the maximum possible size. Malicious netlink clients could send shorter attribute and thus resulting a kernel read after the buffer. The patch adds the explicit length checkings. Reported-