Re: [PATCH nf] netfilter: nft_dynset: fix incorrect element expiration calculation

2016-11-20 Thread Liping Zhang
2016-11-20 17:38 GMT+08:00 Anders K. Pedersen | Cohaesio : [...] > I believe that updating elements in dynsets can happen much more > frequently than interactions with userspace. One of my own use cases is Make sense. Considering the performance cost, your patch looks better:) > traffic accountin

Re: [PATCH nf] netfilter: nft_dynset: fix incorrect element expiration calculation

2016-11-20 Thread Anders K. Pedersen | Cohaesio
Hi Liping, On søn, 2016-11-20 at 14:18 +0800, Liping Zhang wrote: > After commit a8b1e36d0d1d ("netfilter: nft_dynset: fix element > timeout > for HZ != 1000"), priv->timeout was stored in jiffies, while > set->timeout was stored in milliseconds. This is inconsistent and > incorrect. > > Firstly,

[PATCH nf] netfilter: nft_dynset: fix incorrect element expiration calculation

2016-11-19 Thread Liping Zhang
From: Liping Zhang After commit a8b1e36d0d1d ("netfilter: nft_dynset: fix element timeout for HZ != 1000"), priv->timeout was stored in jiffies, while set->timeout was stored in milliseconds. This is inconsistent and incorrect. Firstly, we already call msecs_to_jiffies in nft_set_elem_init, so p