Re: [PATCH nf-next 2/6] netfilter: nat: convert nat bysrc hash to rhashtable

2016-07-11 Thread Pablo Neira Ayuso
On Tue, Jul 05, 2016 at 12:07:24PM +0200, Florian Westphal wrote: > It did use a fixed-size bucket list plus single lock to protect add/del. > > Unlike the main conntrack table we only need to add and remove keys. > Convert it to rhashtable to get table autosizing and per-bucket locking. > > The

[PATCH nf-next 2/6] netfilter: nat: convert nat bysrc hash to rhashtable

2016-07-05 Thread Florian Westphal
It did use a fixed-size bucket list plus single lock to protect add/del. Unlike the main conntrack table we only need to add and remove keys. Convert it to rhashtable to get table autosizing and per-bucket locking. The maximum number of entries is -- as before -- tied to the number of conntracks