Re: [PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-05 Thread Liping Zhang
Hi Pablo, 2017-06-06 8:04 GMT+08:00 Pablo Neira Ayuso : [...] >> I remembered Pablo told me that the ct helpers "is probably one of >> the remaining subsystems not having netns support", when I sent >> patches to fix other issues. >> >> So I try to accomplish the netns

Re: [PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-05 Thread Pablo Neira Ayuso
On Mon, Jun 05, 2017 at 01:11:19PM +0800, Liping Zhang wrote: > Hi Florian & Pablo, > > 2017-06-05 0:07 GMT+08:00 Florian Westphal : > > Liping Zhang wrote: > >> This patch set aims to add net namespace support for the ct helper, > >> it is a little large, but

Re: [PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-04 Thread Liping Zhang
Hi Florian & Pablo, 2017-06-05 0:07 GMT+08:00 Florian Westphal : > Liping Zhang wrote: >> This patch set aims to add net namespace support for the ct helper, >> it is a little large, but I try my best to split them to a relative >> smaller patches, which will

Re: [PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-04 Thread Pablo Neira Ayuso
On Sun, Jun 04, 2017 at 06:07:53PM +0200, Florian Westphal wrote: > Liping Zhang wrote: > > This patch set aims to add net namespace support for the ct helper, > > it is a little large, but I try my best to split them to a relative > > smaller patches, which will help to

Re: [PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-04 Thread Florian Westphal
Liping Zhang wrote: > This patch set aims to add net namespace support for the ct helper, > it is a little large, but I try my best to split them to a relative > smaller patches, which will help to review. Comments are welcome. Why? Could you explain what kind of

[PATCH nf-next RFC 0/5] netfilter: add net namespace support for cthelper

2017-06-04 Thread Liping Zhang
This patch set aims to add net namespace support for the ct helper, it is a little large, but I try my best to split them to a relative smaller patches, which will help to review. Comments are welcome. Actually, I split the whole thing into 4 parts: 1. make nf_conntrack_helper_register become