Re: [PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

2016-11-02 Thread Davide Caratti
On Tue, 2016-11-01 at 23:11 +0100, Pablo Neira Ayuso wrote: > Minor nitpicks as I said, see below. > hello Pablo, thank you for reviewing! > On Fri, Oct 28, 2016 at 10:42:09AM +0200, Davide Caratti wrote: > > > >  static struct pernet_operations ipv4_net_ops = { > > @@ -410,37 +397,21 @@

Re: [PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

2016-11-01 Thread Pablo Neira Ayuso
Minor nitpicks as I said, see below. On Fri, Oct 28, 2016 at 10:42:09AM +0200, Davide Caratti wrote: > modify registration and deregistration of layer-4 protocol trackers to > facilitate inclusion of new elements into the current list of builtin > protocols. Both builtin (TCP, UDP, ICMP) and

Re: [PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

2016-10-28 Thread Pablo Neira Ayuso
On Fri, Oct 28, 2016 at 10:47:52AM +0200, Pablo Neira Ayuso wrote: > On Fri, Oct 28, 2016 at 10:42:09AM +0200, Davide Caratti wrote: > > modify registration and deregistration of layer-4 protocol trackers to > > facilitate inclusion of new elements into the current list of builtin > > protocols.

Re: [PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

2016-10-28 Thread Pablo Neira Ayuso
On Fri, Oct 28, 2016 at 10:42:09AM +0200, Davide Caratti wrote: > modify registration and deregistration of layer-4 protocol trackers to > facilitate inclusion of new elements into the current list of builtin > protocols. Both builtin (TCP, UDP, ICMP) and non-builtin (DCCP, GRE, SCTP, > UDPlite)

[PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

2016-10-28 Thread Davide Caratti
modify registration and deregistration of layer-4 protocol trackers to facilitate inclusion of new elements into the current list of builtin protocols. Both builtin (TCP, UDP, ICMP) and non-builtin (DCCP, GRE, SCTP, UDPlite) layer-4 protocol trackers usually register/deregister themselves using