Re: [PATCH nf 1/1] netfilter: cttimeout: Fix one possible use-after-free issue

2017-04-13 Thread Pablo Neira Ayuso
On Fri, Apr 14, 2017 at 06:35:13AM +0800, Gao Feng wrote: > > -Original Message- > > From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > > On Thu, Apr 06, 2017 at 07:09:09PM +0800, gfree.w...@foxmail.com wrote: > > > > > > The function ctnl_untimeout is used to untimeout every conntrack

RE: [PATCH nf 1/1] netfilter: cttimeout: Fix one possible use-after-free issue

2017-04-13 Thread Gao Feng
> -Original Message- > From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > On Thu, Apr 06, 2017 at 07:09:09PM +0800, gfree.w...@foxmail.com wrote: > > > > The function ctnl_untimeout is used to untimeout every conntrack which > > is using the timeout. But it is necessary to add one

Re: [PATCH nf 1/1] netfilter: cttimeout: Fix one possible use-after-free issue

2017-04-13 Thread Pablo Neira Ayuso
On Thu, Apr 06, 2017 at 07:09:09PM +0800, gfree.w...@foxmail.com wrote: > From: Gao Feng > > The function ctnl_untimeout is used to untimeout every conntrack > which is using the timeout. But it is necessary to add one barrier > synchronize_rcu because of racing. Maybe one

[PATCH nf 1/1] netfilter: cttimeout: Fix one possible use-after-free issue

2017-04-06 Thread gfree . wind
From: Gao Feng The function ctnl_untimeout is used to untimeout every conntrack which is using the timeout. But it is necessary to add one barrier synchronize_rcu because of racing. Maybe one conntrack has already owned this timeout, but it is not inserted into unconfirmed list