Re: [PATCH nf v3] netfilter: xt_CT: fix refcnt leak on error path

2017-04-25 Thread Pablo Neira Ayuso
On Fri, Apr 14, 2017 at 10:00:08AM +0800, gfree.w...@foxmail.com wrote: > From: Gao Feng > > There are two cases which causes refcnt leak. > > 1. When nf_ct_timeout_ext_add failed in xt_ct_set_timeout, it should > free the timeout refcnt. > Now goto the err_put_timeout error handler instead of g

[PATCH nf v3] netfilter: xt_CT: fix refcnt leak on error path

2017-04-13 Thread gfree . wind
From: Gao Feng There are two cases which causes refcnt leak. 1. When nf_ct_timeout_ext_add failed in xt_ct_set_timeout, it should free the timeout refcnt. Now goto the err_put_timeout error handler instead of going ahead. 2. When the time policy is not found, we should call module_put. Otherwis