Re: [PATCH 2/4 v6] libnftnl: rule: Change the "userdata" attribute to use new TLV buffer

2016-04-15 Thread Pablo Neira Ayuso
On Thu, Apr 14, 2016 at 07:55:42PM +0200, Carlos Falgueras García wrote: > I don't understand. With the modification to the patch [4/4 v6] you made, > there is still a data copy and it is passed in the same way. This copy has > moved from libnftnl to nft, but it still exists. This is an old bug,

Re: [PATCH 2/4 v6] libnftnl: rule: Change the "userdata" attribute to use new TLV buffer

2016-04-14 Thread Carlos Falgueras García
On 14/04/16 01:59, Pablo Neira Ayuso wrote: On Tue, Mar 22, 2016 at 08:46:25PM +0100, Carlos Falgueras García wrote: diff --git a/src/rule.c b/src/rule.c index 3a32bf6..db96e5b 100644 --- a/src/rule.c +++ b/src/rule.c @@ -28,6 +28,7 @@ #include #include #include +#include struct

Re: [PATCH 2/4 v6] libnftnl: rule: Change the "userdata" attribute to use new TLV buffer

2016-04-13 Thread Pablo Neira Ayuso
On Tue, Mar 22, 2016 at 08:46:25PM +0100, Carlos Falgueras García wrote: > diff --git a/src/rule.c b/src/rule.c > index 3a32bf6..db96e5b 100644 > --- a/src/rule.c > +++ b/src/rule.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > > struct nftnl_rule { > struct