Re: [PATCH nft] src: osf: add ttl option support

2018-09-27 Thread Pablo Neira Ayuso
On Wed, Sep 26, 2018 at 08:53:08PM +0200, Fernando Fernandez Mancera wrote: > Sorry if I have misunderstood you but right now, the function implements > 'ttl nocheck' and 'ttl global' behaviours. Yes I am going to document that > the default behaviour is 'ttl local'. > > So if I am not wrong this

Re: [PATCH nft] src: osf: add ttl option support

2018-09-26 Thread Fernando Fernandez Mancera
On 9/18/18 1:16 AM, Pablo Neira Ayuso wrote: On Sun, Sep 16, 2018 at 09:11:12PM +0200, Fernando Fernandez Mancera wrote: Add support for ttl option in "osf" expression. Example: table ip foo { chain bar {     type filter hook input priority filter; policy accept;     osf ttl 0 name

Re: [PATCH nft] src: osf: add ttl option support

2018-09-26 Thread Fernando Fernandez Mancera
Sorry if I have misunderstood you but right now, the function implements 'ttl nocheck' and 'ttl global' behaviours. Yes I am going to document that the default behaviour is 'ttl local'. So if I am not wrong this doesn't require changes. Did you mean something different or it is fine? Thanks!

Re: [PATCH nft] src: osf: add ttl option support

2018-09-18 Thread Fernando Fernandez Mancera
On 9/18/18 1:16 AM, Pablo Neira Ayuso wrote: On Sun, Sep 16, 2018 at 09:11:12PM +0200, Fernando Fernandez Mancera wrote: Add support for ttl option in "osf" expression. Example: table ip foo { chain bar { type filter hook input priority filter; policy accept;

Re: [PATCH nft] src: osf: add ttl option support

2018-09-17 Thread Pablo Neira Ayuso
On Sun, Sep 16, 2018 at 09:11:12PM +0200, Fernando Fernandez Mancera wrote: > Add support for ttl option in "osf" expression. Example: > > table ip foo { > chain bar { > type filter hook input priority filter; policy accept; > osf ttl 0 name "Linux" Looking at

Re: [PATCH nft] src: osf: add ttl option support

2018-09-16 Thread Fernando Fernandez Mancera
I have not implemented tests and json support yet because I prefer to do it after the review of this patchset. Thanks! On 9/16/18 9:11 PM, Fernando Fernandez Mancera wrote: Add support for ttl option in "osf" expression. Example: table ip foo { chain bar { type filter