Re: [nf-next 2/3] netfilter: Add support for IPv6 segment routing 'SEG6' target

2018-08-21 Thread Ahmed Abdelsalam
Thanks Florian! I'll send a v2 addressing the comments. Ahmed On Tue, 21 Aug 2018 18:13:08 +0200 Florian Westphal wrote: > Ahmed Abdelsalam wrote: > > +static int seg6_check(const struct xt_tgchk_param *par) > > +{ > > + /** > > +* In the future, some new action may require using > > +

Re: [nf-next 2/3] netfilter: Add support for IPv6 segment routing 'SEG6' target

2018-08-21 Thread Florian Westphal
Ahmed Abdelsalam wrote: > +static int seg6_check(const struct xt_tgchk_param *par) > +{ > + /** > + * In the future, some new action may require using > + * this function for doing some checks > + */ Please add add a check on seg6->action and return -EOPNOSTUPP in case it

Re: [nf-next 2/3] netfilter: Add support for IPv6 segment routing 'SEG6' target

2018-08-16 Thread Ahmed Abdelsalam
We depend on IPV6_SEG6_LWTUNNEL only to be sure that three sympols seg6_get_srh(), seg6_advance_nextseg(), and seg6_lookup_nexthop exist. On the other hand, the actions go-next, skip-next, and go-last are based the ip6tables SRH match of previous, next and last sid.

Re: [nf-next 2/3] netfilter: Add support for IPv6 segment routing 'SEG6' target

2018-08-16 Thread Pablo Neira Ayuso
On Thu, Aug 16, 2018 at 04:51:42PM +0200, Ahmed Abdelsalam wrote: [...] > diff --git a/net/ipv6/netfilter/Kconfig b/net/ipv6/netfilter/Kconfig > index 339d0762b027..a2502c54a837 100644 > --- a/net/ipv6/netfilter/Kconfig > +++ b/net/ipv6/netfilter/Kconfig > @@ -344,6 +344,21 @@ config