Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Liping Zhang
2016-09-28 11:08 GMT+08:00 Liping Zhang : > Hi Feng, > > 2016-09-28 9:23 GMT+08:00 Feng Gao : >> Hi Aaraon, >> >> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >>> It's possible for nf_hook_entry_head to return NULL if two >>>

[ANNOUNCE] Netdev 1.2 updates (27th September, 2016)

2016-09-27 Thread Hajime Tazaki
Hello folks, The Linux netdev 1.2 conference will start on next week and I hope everyone is ready to join us. == program == The full list of accepted sessions (keynotes, workshops, talks, bofs) are available at the following page. http://netdevconf.org/1.2/accepted-sessions.html We will have

[PATCH v2] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

2016-09-27 Thread Vishwanath Pai
v2: Remove unnecessary div64_u64 around constants -- Fix link error in 32bit arch because of 64bit division Division of 64bit integers will cause linker error undefined reference to `__udivdi3'. Fix this by replacing divisions with div64_64 Signed-off-by: Vishwanath Pai ---

[PATCH nf-next v2 0/2] fixes for recent nf_compact hooks

2016-09-27 Thread Aaron Conole
Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Aaron Conole
It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole ---

Re: [PATCH] Fix link error in 32bit arch because of 64bit division

2016-09-27 Thread Eric Dumazet
On Tue, 2016-09-27 at 03:42 -0400, Vishwanath Pai wrote: > Fix link error in 32bit arch because of 64bit division > > Division of 64bit integers will cause linker error undefined reference > to `__udivdi3'. Fix this by replacing divisions with div64_64 > > Signed-off-by: Vishwanath Pai

Re: [PATCH] Fix link error in 32bit arch because of 64bit division

2016-09-27 Thread Liping Zhang
Hi Vishwanath Pai, 2016-09-27 15:42 GMT+08:00 Vishwanath Pai : > Fix link error in 32bit arch because of 64bit division This should be "netfilter: xt_hashlimit: fix ... " > > --- a/net/netfilter/xt_hashlimit.c > +++ b/net/netfilter/xt_hashlimit.c > @@ -465,19 +465,20 @@ static

[PATCH] Fix link error in 32bit arch because of 64bit division

2016-09-27 Thread Vishwanath Pai
Fix link error in 32bit arch because of 64bit division Division of 64bit integers will cause linker error undefined reference to `__udivdi3'. Fix this by replacing divisions with div64_64 Signed-off-by: Vishwanath Pai --- net/netfilter/xt_hashlimit.c | 15 --- 1

Re: [PATCH nf-next] netfilter: xt_osf: Use explicit member assignment to avoid implicit no padding rule

2016-09-27 Thread Liping Zhang
Hi Feng, 2016-09-27 14:00 GMT+08:00 Gao Feng : > Hi Liping, > >> >> This xt_osf_user_finger{} is carefully designed, no padding now, and >> will not be changed in the future, otherwise backward compatibility will >> be broken. > > Yes, there is no padding now. So it is ok to use

Re: [PATCH nf-next] netfilter: xt_osf: Use explicit member assignment to avoid implicit no padding rule

2016-09-27 Thread Gao Feng
Hi Liping, On Tue, Sep 27, 2016 at 1:49 PM, Liping Zhang wrote: > Hi Feng, > > 2016-09-27 12:39 GMT+08:00 : >> From: Gao Feng >> >> Current xt_osf codes use memcmp to check if two user fingers are same, >> so it depends on that the struct