[nft PATCH 2/4] netlink: Fix segfault when using --echo flag

Commit 07b45939972eb ("src: introduce struct nft_cache") added cache pointer to struct netlink_mon_handler and the code assumes it is never NULL. Therefore initialize it in the dummy version of netlink_mon_handler in netlink_echo_callback(). Fixes: b99c4d072d996 ("Implement --echo option")

[nft PATCH 4/4] tests: Merge monitor and echo test suites

The two test suites were pretty similar already, and since echo output is supposed to be identical to monitor output apart from delete commands, they can be merged together with litte effort. Signed-off-by: Phil Sutter --- tests/echo/run-tests.sh | 45

[nft PATCH 0/4] A bunch of fixes for echo output

This series addresses the shortcomings of my echo option implementation pointed out by Pablo. In addition to that, I figured that test suites for monitor and echo are pretty similar so I merged both into one. Phil Sutter (4): mnl: Drop --echo support for non-batch calls netlink: Fix segfault

[nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

Echo support in nft_mnl_talk() was broken: nft_mnl_talk_cb() passed cbdata->data as second parameter to netlink_echo_callback() which expected it to be of type struct netlink_ctx while in fact it was whatever callers of nft_mnl_talk() passed as callback data (in most cases a NULL pointer). I

[nft PATCH 3/4] echo: Fix for added delays in rule updates

The added cache update upon every command dealing with rules was a bummer. Instead, perform the needed cache update only if echo option was set. Initially, I tried to perform the cache update from within netlink_echo_callback(), but that turned into a mess since the shared socket between

Re: [PATCH] man: use https for wiki link

On Mon, Aug 14, 2017 at 01:27:11PM -0400, Daniel Kahn Gillmor wrote: > https works for the wiki, and users should prefer it by default, > whether they are logging in (to protect their credentials) or whether > they're reading data (to protect the integrity of the content). Applied, thanks. -- To

[PATCH] man: use https for wiki link

https works for the wiki, and users should prefer it by default, whether they are logging in (to protect their credentials) or whether they're reading data (to protect the integrity of the content). Signed-off-by: Daniel Kahn Gillmor Acked-by: Arturo Borrero Gonzalez

Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning

Minor nit for the commit message that can get fixed up when being merged: On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers wrote: > if (x) > return > ... > > rather than: > > if (!x == 0) should remove the `!`, ex: if (x == 0) > ... > else > return --

Re: [nft PATCH v4 0/3] Implement --echo option

On Mon, Aug 14, 2017 at 01:54:39PM +0200, Phil Sutter wrote: > On Mon, Aug 14, 2017 at 01:43:22PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Aug 14, 2017 at 01:36:44PM +0200, Phil Sutter wrote: > > > On Mon, Aug 14, 2017 at 11:26:51AM +0200, Pablo Neira Ayuso wrote: > > > > On Wed, Aug 09, 2017

Re: [nft PATCH v4 0/3] Implement --echo option

On Mon, Aug 14, 2017 at 01:43:22PM +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 14, 2017 at 01:36:44PM +0200, Phil Sutter wrote: > > On Mon, Aug 14, 2017 at 11:26:51AM +0200, Pablo Neira Ayuso wrote: > > > On Wed, Aug 09, 2017 at 01:16:40PM +0200, Phil Sutter wrote: > > > > Long description of

Re: [nft PATCH v4 0/3] Implement --echo option

On Mon, Aug 14, 2017 at 01:36:44PM +0200, Phil Sutter wrote: > On Mon, Aug 14, 2017 at 11:26:51AM +0200, Pablo Neira Ayuso wrote: > > On Wed, Aug 09, 2017 at 01:16:40PM +0200, Phil Sutter wrote: > > > Long description of what it is and how it works in patch 3. Patch 1 is a > > > dependency to

Re: [nft PATCH v4 0/3] Implement --echo option

On Mon, Aug 14, 2017 at 11:26:51AM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 09, 2017 at 01:16:40PM +0200, Phil Sutter wrote: > > Long description of what it is and how it works in patch 3. Patch 1 is a > > dependency to patch 2, Patch 3 adds a simple test suite which was > > helpful during

Re: [nft PATCH v4 2/3] Implement --echo option

On Wed, Aug 09, 2017 at 01:16:42PM +0200, Phil Sutter wrote: > diff --git a/include/nftables.h b/include/nftables.h > index 640d3c7e715d8..ca609015274a9 100644 > --- a/include/nftables.h > +++ b/include/nftables.h > @@ -29,6 +29,7 @@ struct output_ctx { > unsigned int stateless; >

Re: [PATCH nft] man: Fix typo.

On Sun, Aug 06, 2017 at 04:44:21PM +0530, Varsha Rao wrote: > The word 'occur' is misspelled as 'ocurr'. This patch fixes it. Also applied. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH iptables 2/2] xtables-compat: fix memory leak when listing

On Tue, Aug 08, 2017 at 08:53:46PM +0200, Pablo M. Bermudo Garay wrote: > The following memory leaks are detected by valgrind when > ip[6]tables-compat is used for listing operations: Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body

Re: [PATCH iptables 1/2] xtables-compat-restore: fix several memory leaks

On Tue, Aug 08, 2017 at 08:53:45PM +0200, Pablo M. Bermudo Garay wrote: > The following memory leaks are detected by valgrind when > ip[6]tables-compat-restore is executed: > > valgrind --leak-check=full iptables-compat-restore test-ruleset Applied, thanks. -- To unsubscribe from this list: send

Re: [conntrack-tools PATCH] conntrackd: remove warning for -S

On Wed, Aug 09, 2017 at 02:19:32PM +0200, Arturo Borrero Gonzalez wrote: > Remove the warning message for the -S option which has been deprecated for > years now. > > Users calling conntrackd with this switch activated will now get an error. Applied, thanks Arturo. -- To unsubscribe from this