info!!

2018-07-10 Thread Lee Morrow
Top of the day to you, this is in respect of a very beneficial transaction which you would not want to let go reply for more details, Regards, Lee -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH nft] tests: shell: add tests for listing objects

2018-07-10 Thread Harsha Sharma
Add tests for listing specific object for a given table name and all objects of a table. Signed-off-by: Harsha Sharma --- tests/shell/testcases/listing/0013objects_0 | 33 + tests/shell/testcases/listing/0014objects_0 | 24 + 2 files changed, 57

[PATCH V2 nf 3/3] netfilter: nf_tables: add default set size

2018-07-10 Thread Taehee Yoo
In order to restrict element number of each set, member ->size is used. that used to be given by user-space. if user-space don't specify ->size, number of element is unlimited. so that overflow can occurred. After this patch, If user-space don't specify ->size, 65535 is set. all types of set have

[PATCH V2 nf 2/3] netfilter: nft_set_rbtree: fix panic when destroying set by GC

2018-07-10 Thread Taehee Yoo
This patch fixes below. 1. check null pointer of rb_next. rb_next can return null. so null check routine should be added. 2. add rcu_barrier in destroy routine. GC uses call_rcu to remove elements. but all elements should be removed before destroying set and chains. so that rcu_barrier is

[PATCH V2 nf 1/3] netfilter: nft_set_hash: add rcu_barrier() in the nft_rhash_destroy()

2018-07-10 Thread Taehee Yoo
GC of set uses call_rcu() to destroy elements. So that elements would be destroyed after destroying sets and chains. But, elements should be destroyed before destroying sets and chains. In order to wait calling call_rcu(), a rcu_barrier() is added. In order to test correctly, below patch should

[PATCH V2 nf 0/3] netfilter: nf_tables: fix set destroying bugs

2018-07-10 Thread Taehee Yoo
This patch series fixes nft_set_hash and nft_set_rbtree bugs. First patch adds rcu_barrier in the nft_rhash_destroy() to wait completion of call_rcu by GC. Second patch fixes bugs in nft_set_rbtree.c - add null check routine - add rcu_barrier in destroy routine Last patch adds default

[PATCH v2 nf-next] netfilter: Kconfig: Change select dependencies from IPV6 to NF_TABLES_IPV6 and IP6_NF_IPTABLES

2018-07-10 Thread Máté Eckl
In some cases module selects depend on IPV6, but this means that they select another module even if eg. NF_TABLES_IPV6 is not set in which case the selected module is useless due to the lack of IPv6 nf_tables functionality. The same applies for IP6_NF_IPTABLES and iptables. Joint work with: Arnd

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Florian Westphal
Pablo Neira Ayuso wrote: > Florian, do you think it's worth placing this somewhere at > netfilter.org? No idea, but i wouldn't mind placing/moving this thing to nf.org. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Pablo Neira Ayuso
On Tue, Jul 10, 2018 at 01:41:31PM +0200, Máté Eckl wrote: > On Tue, Jul 10, 2018 at 01:26:41PM +0200, Pablo Neira Ayuso wrote: > > On Tue, Jul 10, 2018 at 01:19:21PM +0200, Máté Eckl wrote: [...] > > > I planned to add this to Documentation/networking/tproxy.txt. Should I do > > > it in > > >

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Martynas Pumputis
On 10 July 2018 at 13:37, Pablo Neira Ayuso wrote: > On Mon, Jul 02, 2018 at 04:52:14PM +0200, Martynas Pumputis wrote: >> This patch enables the clash resolution for NAT (disabled in >> "590b52e10d41") if clashing conntracks match (i.e. both tuples are equal) >> and a protocol allows it. >> >>

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Máté Eckl
On Tue, Jul 10, 2018 at 01:26:41PM +0200, Pablo Neira Ayuso wrote: > On Tue, Jul 10, 2018 at 01:19:21PM +0200, Máté Eckl wrote: > > On Tue, Jul 10, 2018 at 12:54:24PM +0200, Pablo Neira Ayuso wrote: > > [...] > > > > > Please, could you describe how you have tested the nft tproxy > > > > >

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Pablo Neira Ayuso
On Mon, Jul 02, 2018 at 04:52:14PM +0200, Martynas Pumputis wrote: > This patch enables the clash resolution for NAT (disabled in > "590b52e10d41") if clashing conntracks match (i.e. both tuples are equal) > and a protocol allows it. > > The clash might happen for a connections-less protocol

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Pablo Neira Ayuso
On Tue, Jul 10, 2018 at 01:23:01PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > I see, so this is just solving the conflict for a specific usecase > > with NAT in place, ie. get_unique_tuple() returns same tuple... > > > > But how so? With NAT in place, the packet losing race

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Martynas Pumputis
On 10 July 2018 at 13:23, Florian Westphal wrote: > Pablo Neira Ayuso wrote: >> I see, so this is just solving the conflict for a specific usecase >> with NAT in place, ie. get_unique_tuple() returns same tuple... >> >> But how so? With NAT in place, the packet losing race will eventually >> get

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Pablo Neira Ayuso
On Tue, Jul 10, 2018 at 01:19:21PM +0200, Máté Eckl wrote: > On Tue, Jul 10, 2018 at 12:54:24PM +0200, Pablo Neira Ayuso wrote: > [...] > > > > Please, could you describe how you have tested the nft tproxy > > > > datapath? Did you run any example configuration to make sure things > > > > are

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Florian Westphal
Pablo Neira Ayuso wrote: > I see, so this is just solving the conflict for a specific usecase > with NAT in place, ie. get_unique_tuple() returns same tuple... > > But how so? With NAT in place, the packet losing race will eventually > get a different tuple, given the tuple that the first packet

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Máté Eckl
On Tue, Jul 10, 2018 at 12:54:24PM +0200, Pablo Neira Ayuso wrote: [...] > > > Please, could you describe how you have tested the nft tproxy > > > datapath? Did you run any example configuration to make sure things > > > are working? If so, please slightly describe. > > > > > > Thanks. > > > > I

Re: [PATCH v2] netfilter: nf_conntrack: resolve clash for matching conntracks

2018-07-10 Thread Pablo Neira Ayuso
On Mon, Jul 09, 2018 at 08:42:17PM +0200, Martynas Pumputis wrote: > On 9 July 2018 at 20:12, Pablo Neira Ayuso wrote: [...] > >> The idea of this patch is to resolve the conflict only among packets > >> with the same mangling (= with matching tuples). The mangling happens > >> before the

Re: [PATCH v4 nft] Set/print standard chain prios with textual names

2018-07-10 Thread Pablo Neira Ayuso
On Tue, Jul 10, 2018 at 12:52:25PM +0200, Máté Eckl wrote: [...] > Destination nat (dnat/dstnat) is a well-known expression among sysadmins and > netadmins so I think this is better than prenat which just seems to be a new > word for the same thing. ack. -- To unsubscribe from this list: send the

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Pablo Neira Ayuso
On Tue, Jul 10, 2018 at 12:39:54PM +0200, Máté Eckl wrote: > On Mon, Jul 09, 2018 at 05:40:38PM +0200, Pablo Neira Ayuso wrote: > > Hi Máté, > > > > On Thu, Jun 28, 2018 at 06:42:58PM +0200, Máté Eckl wrote: > > > v2: > > > - address or port is now compulsory > > > - nf_defrag_ipv{4,6}_enable

Re: [PATCH v4 nft] Set/print standard chain prios with textual names

2018-07-10 Thread Máté Eckl
On Tue, Jul 10, 2018 at 12:10:22PM +0200, Pablo Neira Ayuso wrote: > Hi, > > On Mon, Jul 09, 2018 at 04:44:53PM +0200, Máté Eckl wrote: > [...] > > Example: > > nft> add table ip x > > nft> add chain ip x y { type filter hook prerouting priority raw; } > > nft> add chain ip x z { type filter hook

Re: [PATCH v2 nf-next] netfilter: Add native tproxy support for nf_tables

2018-07-10 Thread Máté Eckl
On Mon, Jul 09, 2018 at 05:40:38PM +0200, Pablo Neira Ayuso wrote: > Hi Máté, > > On Thu, Jun 28, 2018 at 06:42:58PM +0200, Máté Eckl wrote: > > v2: > > - address or port is now compulsory > > - nf_defrag_ipv{4,6}_enable called in init > > - nft_tproxy now selects NF_DEFRAG_IPV4/6 > > - Add

Re: [PATCH] rule: obj: list only the table containing object

2018-07-10 Thread Pablo Neira Ayuso
On Sun, Jul 08, 2018 at 12:41:03PM +0200, Harsha Sharma wrote: > For e.g. > > %nft list ct helper ip raw cthelp1 > table ip filter { > } > table ip raw { > ct helper cthelp1 { > type "ftp" protocol tcp > l3proto ip > } > } > With this patch, print only

Re: [PATCH nf-next v6] netfilter: nft_ct: add ct timeout support

2018-07-10 Thread Pablo Neira Ayuso
On Fri, Jul 06, 2018 at 01:47:58AM +0200, Harsha Sharma wrote: > This patch allows to add, list and delete connection tracking timeout > policies via nft objref infrastructure and assigning these timeout > via nft rule. > > Ruleset: > > table ip raw { >ct timeout cttime { >protocol

Re: [PATCH] iptables: tests: add test for iptables-save and iptables-restore

2018-07-10 Thread Pablo Neira Ayuso
On Mon, Jul 09, 2018 at 01:07:59PM +0530, Arushi Singhal wrote: > Add test for testing if iptables configuration is restored and saved. Applied, thanks. BTW, I think it may be a good idea to move these tools to the root directory, instead of using the iptables folder. I can just make it here if

Re: [PATCH v4 nft] Set/print standard chain prios with textual names

2018-07-10 Thread Pablo Neira Ayuso
Hi, On Mon, Jul 09, 2018 at 04:44:53PM +0200, Máté Eckl wrote: [...] > Example: > nft> add table ip x > nft> add chain ip x y { type filter hook prerouting priority raw; } > nft> add chain ip x z { type filter hook prerouting priority mangle + 1; } Nice stuff. > nft> add chain ip x w { type

Re: [ANNOUNCE] iptables 1.8.0 release

2018-07-10 Thread Florian Westphal
Jan Engelhardt wrote: > >nf_tables commandline tools: > >ip6tables-nft-save ip6tables-nft-restore ip6tables-nft > >iptables-nft-save iptables-nft-restore iptables-nft > > With the distro hat on, I found that the "arptables" and "ebtables" > programs in iptables.git could perhaps be named

Re: [ANNOUNCE] iptables 1.8.0 release

2018-07-10 Thread Jan Engelhardt
On Friday 2018-07-06 11:32, Florian Westphal wrote: >iptables 1.8 > >This release introduces a more prominent distinction between the >'classic' iptables and 'new' iptables front-end that internally uses the >nf_tables API to talk to the kernel. > >legacy commandline tools:

Re: [PATCH nf 0/4] netfilter: nf_tables: fix set destroying bugs

2018-07-10 Thread Taehee Yoo
2018-07-09 22:56 GMT+09:00 Pablo Neira Ayuso : > On Sun, Jul 01, 2018 at 08:43:16PM +0900, Taehee Yoo wrote: >> This patch series fixes nft_set_hash and nft_set_rbtree bugs. >> >> First patch adds nft_rhash_iterate_destroy(). >> it walks and destroys all elements. >> >> Second patch adds

Re: [PATCH nf 3/4] netfilter: nft_set_rbtree: fix panic when destroying set by GC

2018-07-10 Thread Taehee Yoo
2018-07-09 22:48 GMT+09:00 Pablo Neira Ayuso : > On Tue, Jul 03, 2018 at 11:40:06PM +0900, Taehee Yoo wrote: >> 2018-07-03 19:20 GMT+09:00 Pablo Neira Ayuso : >> > On Sun, Jul 01, 2018 at 08:44:52PM +0900, Taehee Yoo wrote: >> >> This patch fixes below. >> >> 1. check null pointer of rb_next. >>

Re: [PATCH] netfilter: NFT_SOCKET don't use NF_SOCKET_IPV6 without NF_TABLES_IPV6

2018-07-10 Thread Máté Eckl
On Mon, Jul 09, 2018 at 11:35:09PM +0200, Arnd Bergmann wrote: > It is now possible to build the nft_socket module as built-in when > NF_TABLES_IPV6 is disabled, and have NF_SOCKET_IPV6=m set manually. > > In this case, the NF_SOCKET_IPV6 functionality will be useless according > to the