Re: dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Roman Mamedov
On Tue, 14 Aug 2018 15:19:27 -0700 "Doug Smythies" wrote: > I don't know what to say, it is 100% repeatable for me, on multiple > computers. I do not doubt that, just curious what's the configuration difference and how I still didn't hit that. > There has to be some traffic on the SSH session

RE: dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Doug Smythies
Hi Florian, Thanks for your quick reply, and the time you took to do it. On 2018.08.14 11:01 Florian Westphal wrote: > Doug Smythies wrote: >> Sometimes it is desirable to temporarily disable, or clear, >> the iptables rule set on a computer being controlled via a >> secure shell session (SSH).

RE: dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Doug Smythies
On 2018.08.14 13:43 Roman Mamedov wrote: > On Tue, 14 Aug 2018 08:48:18 -0700 > "Doug Smythies" wrote: > >> Sometimes it is desirable to temporarily disable, or clear, >> the iptables rule set on a computer being controlled via a >> secure shell session (SSH). While unwise on an internet facing

Re: dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Roman Mamedov
On Tue, 14 Aug 2018 08:48:18 -0700 "Doug Smythies" wrote: > Sometimes it is desirable to temporarily disable, or clear, > the iptables rule set on a computer being controlled via a > secure shell session (SSH). While unwise on an internet facing > computer, I also do it often on non-internet

[PATCH nf-next] netfilter: nft_tproxy: Fix missing-braces warning

2018-08-14 Thread Máté Eckl
This patch fixes a warning reported by the kbuild test robot (from linux-next tree): net/netfilter/nft_tproxy.c: In function 'nft_tproxy_eval_v6': >> net/netfilter/nft_tproxy.c:85:9: warning: missing braces around initializer >> [-Wmissing-braces] struct in6_addr taddr = {0};

[iptables PATCH] xtables: Fix for no output in iptables-nft -S

2018-08-14 Thread Phil Sutter
Just like with 'iptables-nft -L', we have to make sure the standard set of chains exist for a given table when listing it using '-S' flag. The added code was just copied over from nft_rule_list() which does the same. Signed-off-by: Phil Sutter --- iptables/nft.c | 17 + 1 file

ebtables-nft: user-defined chain policies

2018-08-14 Thread Phil Sutter
Hi Arturo, I see that in your commit[1] you explicitly disable policy setting for user-defined ebtables chains. Is this because ebtables-nft can't support them or was it a design decision? I'm asking because it leads to unexpected results for people using ebtables-nft as a drop-in replacement of

Re: dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Florian Westphal
Doug Smythies wrote: > Sometimes it is desirable to temporarily disable, or clear, > the iptables rule set on a computer being controlled via a > secure shell session (SSH). While unwise on an internet facing > computer, I also do it often on non-internet accessible computers > while testing.

Re: [PATCH 3/3 nft v2] src: osf: import nfnl_osf.c to load osf fingerprints

2018-08-14 Thread Fernando Fernandez Mancera
Thanks you for this review, I am going to send a v3 iteration with the changes done and tested. El 14 de agosto de 2018 16:10:33 CEST, Pablo Neira Ayuso escribió: >On Mon, Aug 13, 2018 at 06:57:08PM +0200, Fernando Fernandez Mancera >wrote: >[...] >> diff --git a/include/nfnl_osf.h

Re: [PATCH v5 nft] Set/print standard chain prios with textual names

2018-08-14 Thread Máté Eckl
On Tue, Aug 14, 2018 at 03:26:16PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 03, 2018 at 10:55:33AM +0200, Máté Eckl wrote: > > This patch adds the possibility to use textual names to set the chain > > priority > > to standard values so that numeric values do not need to be learnt any more >

dropped SSH sessions with kernels >= 4.14 upon iptables clear then load [REGRESSION][BISECTED]

2018-08-14 Thread Doug Smythies
Hi, Sometimes it is desirable to temporarily disable, or clear, the iptables rule set on a computer being controlled via a secure shell session (SSH). While unwise on an internet facing computer, I also do it often on non-internet accessible computers while testing. Recently, this has become

Re: [PATCH] doc: Remove double-spacing in text

2018-08-14 Thread Pablo Neira Ayuso
On Tue, Aug 14, 2018 at 02:31:51PM +1000, Duncan Roe wrote: > Double-spacing in .txt files has no effect on PDF or man page output and > can make it hard to locate phrases when editing, so remove them. Applied, thanks.

Re: [nft PATCH] evaluate: reject: Allow icmpx in inet/bridge families

2018-08-14 Thread Pablo Neira Ayuso
On Mon, Aug 13, 2018 at 06:58:57PM +0200, Phil Sutter wrote: > Commit 3e6ab2b335142 added restraints on reject types for bridge and > inet families but aparently those were too strict: If a rule in e.g. > inet family contained a match which introduced a protocol dependency, > icmpx type rejects

Re: [PATCH 1/3 nft v2] files: osf: copy iptables/utils/pf.os into nftables tree

2018-08-14 Thread Pablo Neira Ayuso
On Tue, Aug 14, 2018 at 03:24:00PM +0200, Fernando Fernandez Mancera wrote: > El 14 de agosto de 2018 15:00:18 CEST, Pablo Neira Ayuso > escribió: > >On Mon, Aug 13, 2018 at 06:57:06PM +0200, Fernando Fernandez Mancera > >wrote: > >> diff --git a/files/osf/Makefile.am b/files/osf/Makefile.am >

Re: [PATCH v5 nft] Set/print standard chain prios with textual names

2018-08-14 Thread Pablo Neira Ayuso
On Fri, Aug 03, 2018 at 10:55:33AM +0200, Máté Eckl wrote: > This patch adds the possibility to use textual names to set the chain priority > to standard values so that numeric values do not need to be learnt any more > for > basic usage. > [...] > Example: > nft> add table ip x > nft> add chain

[PATCH nft] build: remove PDF documentation generation

2018-08-14 Thread Pablo Neira Ayuso
This adds unnecessary complexity to our build infrastructure. People can just manually generate them in PDF in case they need too. So let's keep it simple and remove this. Signed-off-by: Pablo Neira Ayuso --- INSTALL | 2 -- configure.ac | 16

Re: [PATCH] doc: Remove double-spacing in text

2018-08-14 Thread Máté Eckl
On Tue, Aug 14, 2018 at 02:31:51PM +1000, Duncan Roe wrote: > Double-spacing in .txt files has no effect on PDF or man page output and > can make it hard to locate phrases when editing, so remove them. > > Signed-off-by: Duncan Roe Hi, Most (if not all) of these double spaces are produced by