Re: [iptables] extensions: Add tests and description for xt_quota module

2018-10-09 Thread Maciej Żenczykowski
Ah, yes, the (2**64 - 1) + 1 problem. The fact max allowed remaining is (2**64 - 2) is perhaps surprising... should we clamp? or warn? userspace has: if (cb->entry->id == O_REMAIN) info->remain++; should this error out in userspace if we end up at zero? +-m quota --quota 18446744073709551615

[iptables] extensions: Add tests and description for xt_quota module

2018-10-09 Thread Chenbo Feng
From: Chenbo Feng Introduces some iptables tests for the new --remain option in xt_quota module. Add a breif description for how to use the --remain option in the iptables-extension man page. Signed-off-by: Chenbo Feng --- extensions/libxt_quota.man | 4 extensions/libxt_quota.t | 11

[PATCH nf] netfilter: nft_compat: do not dump private area

2018-10-09 Thread Pablo Neira Ayuso
Zero pad private area, otherwise we expose private kernel pointer to userspace. This patch also zero the tail area after the ->matchsize and ->targetsize that results from XT_ALIGN(). Fixes: 0ca743a55991 ("netfilter: nf_tables: add compatibility layer for x_tables") Signed-off-by: Pablo Neira

[PATCH iptables] extensions: cgroup: fix option parsing for v2

2018-10-09 Thread Pablo Neira Ayuso
Structure layout is different, therefore a new struct xt_option_entry is needed. Fixes: f9efc8cb79c0 ("extensions: add cgroup revision 2") Signed-off-by: Pablo Neira Ayuso --- extensions/libxt_cgroup.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

Re: iptables (nf_tables) error when negating an interface and using protocol port - works fine with classic iptables

2018-10-09 Thread Florian Westphal
Pedretti Fabio wrote: > Hi, I tried iptables 1.8 with the new nf_tables back-end using the > Debian 1.8.0-1~exp1 package with my firewall script. > > It seems to properly load most rules, however I am getting an error > when negating an interface and using protocol ports, which works fine > with

iptables (nf_tables) error when negating an interface and using protocol port - works fine with classic iptables

2018-10-09 Thread Pedretti Fabio
Hi, I tried iptables 1.8 with the new nf_tables back-end using the Debian 1.8.0-1~exp1 package with my firewall script. It seems to properly load most rules, however I am getting an error when negating an interface and using protocol ports, which works fine with classic iptables. Specifically

Re: [PATCH nf-next] netfilter: nf_flow_table: remove flowtable hook flush routine in netns exit routine

2018-10-09 Thread Taehee Yoo
On Tue, 9 Oct 2018 at 08:19, Pablo Neira Ayuso wrote: > > Hi Taehee, > Hi Pablo, Thank you for your review! > I can reproduce it, so this is a bug :-). Still one question below: > > On Tue, Oct 02, 2018 at 02:17:14AM +0900, Taehee Yoo wrote: > [...] > > diff --git