Working test 6

2018-10-15 Thread Judy
Did you get my email from last week? Let me know if you have photos for cutting out or retouching? We are an image team who can do editing for your the web store photos, industry photos or portrait photos. Send photos, we will do testing for you to check quality. Waiting for your reply soon.

Re: [PATCH libnftables] src: remove json support

2018-10-15 Thread Pablo Neira Ayuso
On Mon, Oct 15, 2018 at 05:18:48PM +0200, Phil Sutter wrote: > Hey, > > On Mon, Oct 15, 2018 at 04:45:38PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Oct 15, 2018 at 02:34:21PM +0200, Pablo Neira Ayuso wrote: > > > On Mon, Oct 15, 2018 at 02:08:07PM +0200, Phil Sutter wrote: > > > > On Mon, Oct

Re: [PATCH libnftables] src: remove json support

2018-10-15 Thread Phil Sutter
Hey, On Mon, Oct 15, 2018 at 04:45:38PM +0200, Pablo Neira Ayuso wrote: > On Mon, Oct 15, 2018 at 02:34:21PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Oct 15, 2018 at 02:08:07PM +0200, Phil Sutter wrote: > > > On Mon, Oct 15, 2018 at 01:29:52PM +0200, Pablo Neira Ayuso wrote: > > > > Subject:

Re: [PATCH libnftables] src: remove json support

2018-10-15 Thread Pablo Neira Ayuso
On Mon, Oct 15, 2018 at 02:34:21PM +0200, Pablo Neira Ayuso wrote: > On Mon, Oct 15, 2018 at 02:08:07PM +0200, Phil Sutter wrote: > > On Mon, Oct 15, 2018 at 01:29:52PM +0200, Pablo Neira Ayuso wrote: > > > Subject: [PATCH libnftables] src: remove json support > > ~~~ > >

Re: [PATCH 1/2 nft v2] src: osf: add ttl option support

2018-10-15 Thread Pablo Neira Ayuso
Please send a v3 including tests/py. More comments below. On Sat, Sep 29, 2018 at 12:15:17PM +0200, Fernando Fernandez Mancera wrote: > Add support for ttl option in "osf" expression. Example: > > table ip foo { > chain bar { > type filter hook input priority filter; policy

Re: [PATCH nf-next] netfilter: nf_nat_snmp_basic: add missing helper alias name

2018-10-15 Thread Pablo Neira Ayuso
On Sun, Oct 07, 2018 at 12:17:07AM +0900, Taehee Yoo wrote: > In order to upload helper module automatically, helper alias name > is needed. so that MODULE_ALIAS_NFCT_HELPER() should be added. > And unlike other nat helper modules, the nf_nat_snmp_basic can be > used independently. > helper name

Re: [PATCH libnftables] src: remove json support

2018-10-15 Thread Pablo Neira Ayuso
On Mon, Oct 15, 2018 at 02:08:07PM +0200, Phil Sutter wrote: > On Mon, Oct 15, 2018 at 01:29:52PM +0200, Pablo Neira Ayuso wrote: > > Subject: [PATCH libnftables] src: remove json support > ~~~ > > This is libnftnl, right? :) > > Apart from that: > > Acked-by: Phil

Re: [PATCH] nftables: add support for setting secmark

2018-10-15 Thread Pablo Neira Ayuso
On Thu, Sep 20, 2018 at 09:43:22AM +0200, Christian Göttsche wrote: > Add support for new nft object secmark holding security context strings. > > The following should demonstrate its usage (based on SELinux context): > > # define a tag containing a context string > nft add secmark inet

Re: [nft PATCH] json: Fix memleak in dup_stmt_json()

2018-10-15 Thread Pablo Neira Ayuso
On Fri, Oct 12, 2018 at 05:50:15PM +0200, Phil Sutter wrote: > The variable 'root' is always assigned to after initialization, so there > is no point in initializing it upon declaration. Applied, thanks.

Re: [nft PATCH] parser_json: Fix for ineffective family value checks

2018-10-15 Thread Pablo Neira Ayuso
On Fri, Oct 12, 2018 at 05:23:24PM +0200, Phil Sutter wrote: > Since handle->family is unsigned, checking for value < 0 never yields > true. Overcome this by changing parse_family() to return an error code > and write the parsed family value into a pointer passed as parameter. > > The above

Re: [nft PATCH] Fix memleak in netlink_parse_fwd() error path

2018-10-15 Thread Pablo Neira Ayuso
On Fri, Oct 12, 2018 at 12:54:09PM +0200, Phil Sutter wrote: > Make sure allocated 'stmt' is freed before returning to caller. Applied, thanks.

Re: [nft PATCH] libnftables: Fix memleak in nft_parse_bison_filename()

2018-10-15 Thread Pablo Neira Ayuso
On Fri, Oct 12, 2018 at 01:22:55PM +0200, Phil Sutter wrote: > Allocated scanner object leaks when returning to caller. For some odd > reason, this was missed by the commit referenced below. Applied, thanks.

Re: [nft PATCH 0/8] monitor: Use libnftables for JSON output

2018-10-15 Thread Pablo Neira Ayuso
On Thu, Oct 11, 2018 at 05:48:53PM +0200, Phil Sutter wrote: > This series essentially moves nft monitor JSON output to libnftables (in > patch 7). Patch 8 enhances tests/monitor to get that tested as well (via > passing '-j' parameter to run-tests.sh). The leading six patches are > more or less

Re: [PATCH libnftables] src: remove json support

2018-10-15 Thread Phil Sutter
On Mon, Oct 15, 2018 at 01:29:52PM +0200, Pablo Neira Ayuso wrote: > Subject: [PATCH libnftables] src: remove json support ~~~ This is libnftnl, right? :) Apart from that: Acked-by: Phil Sutter Cheers, Phil

Re: [PATCH libnftnl] expr: osf: add ttl option support

2018-10-15 Thread Pablo Neira Ayuso
Applied, thanks.

Re: [PATCH nf-next] netfilter: nf_tables: xfrm: use state family, not hook one

2018-10-15 Thread Pablo Neira Ayuso
On Wed, Oct 10, 2018 at 05:25:47PM +0200, Florian Westphal wrote: > Eyal says: > doesn't the use of nft_pf(pkt) in this context limit the matching of > encapsulated packets to the same family? > > IIUC when an e.g. IPv6-in-IPv4 packet is matched, the nft_pf(pkt) will > be the decapsulated

Re: [iptables PATCH] xtables: Remove target_maxnamelen field

2018-10-15 Thread Pablo Neira Ayuso
On Thu, Oct 11, 2018 at 01:30:38PM +0200, Phil Sutter wrote: > This is a partial revert of commit 9f075031a1973 ("Combine > parse_target() and command_jump() implementations"): Upstream prefers to > reduce max chain name length of arptables by two characters instead of > the introduced struct