Re: [PATCH] netfilter: nf_nat_sip: fix RTP/RTCP source port translations

Hi Pablo, On Tue, Nov 27, 2018 at 12:57 AM Pablo Neira Ayuso wrote: > > Hi Alin, > > On Mon, Nov 05, 2018 at 02:54:53PM +0100, Alin Nastac wrote: > > Perform the same SNAT translation on RTP/RTCP conntracks regardless of > > who sends the first datagram. > > > > Prior to this change, RTP packets

[no subject]

-- -- Guten Tag, Wir sind eine registrierte private Geldverleiher. Wir geben Kredite an Firmen, Einzelpersonen, die ihre finanzielle Status auf der ganzen Welt aktualisieren müssen, mit minimalen jährlichen Zinsen von 2% .reply, wenn nötig. Good Day, We are a registered private money lender. We

Re: [PATCH nf] netfilter: nf_conncount: remove wrong condition check routine

On Sun, Nov 25, 2018 at 06:47:13PM +0900, Taehee Yoo wrote: > All lists in the tree_nodes_free() have both zero count and true dead flag. > Because lists are selected by nf_conncount_gc_list() and that makes that > zero-count and true dead flag. > So that the if statement of tree_nodes_free() is

Re: [PATCH nf v2 0/2] netfilter: fix notifier registration bugs

On Thu, Nov 22, 2018 at 07:59:25PM +0900, Taehee Yoo wrote: > This patch series fix notifier registration bugs. > > First patch adds error handling code for failure of notifier registration. > notifier registration can be failed. so that error handling code are needed. > > Second patch fixes

Re: [PATCH v2] ipv6: Preserve link scope traffic original oif

On Wed, Nov 21, 2018 at 02:00:30PM +0100, Alin Nastac wrote: > When ip6_route_me_harder is invoked, it resets outgoing interface of: > - link-local scoped packets sent by neighbor discovery > - multicast packets sent by MLD host > - multicast packets send by MLD proxy daemon that sets

Re: Did You Receive My Last Mail?

Hello, My name is ms. Reem Al-Hashimi. The UAE minister of state for international cooparation. I got your contact from an email database from your country. I have a financial transaction i would like to discuss with you. Please reply to reem2...@daum.net, for more details if you are

[PATCH v2] netfilter: ipset: replace a strncpy() with strscpy()

To make overflows as obvious as possible and to prevent code from blithely proceeding with a truncated string. This also has a side-effect to fix a compilation warning when using GCC 8.2.1. net/netfilter/ipset/ip_set_core.c: In function 'ip_set_sockfn_get':

[PATCH] netfilter: update comment about get_unique_tuple()

`__ip_conntrack_confirm' in the comments is confusing to newcomers since it has long been replaced with __nf_conntrack_confirm. Signed-off-by: Xiaozhou Liu --- net/netfilter/nf_nat_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_nat_core.c

Re: [PATCH nf] netfilter: xt_TEE: fix build failure

On Mon, 26 Nov 2018 at 20:28, Pablo Neira Ayuso wrote: > > On Mon, Nov 26, 2018 at 06:39:28PM +0900, Taehee Yoo wrote: > > Hi Pablo, > > > > According to Masahiro Yamada, this is Kconfig bug and he is fixing Kconfig. > > https://lkml.org/lkml/2018/11/26/291 > > > > So that I think this patch will

Re: [PATCH nf] netfilter: xt_TEE: fix build failure

On Mon, Nov 26, 2018 at 06:39:28PM +0900, Taehee Yoo wrote: > Hi Pablo, > > According to Masahiro Yamada, this is Kconfig bug and he is fixing Kconfig. > https://lkml.org/lkml/2018/11/26/291 > > So that I think this patch will be useless. > Could you check it up? OK, will keep back your patch

[PATCH nf] netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()

basechain->stats is rcu protected data. And write critical section of basechain->stats data is nft_chain_stats_replace(). The function is executed in commit phase. so that actually commit_mutex lock protects that. Hence commit_mutex lockdep should be used for rcu_dereference_protected() in the

Re: [PATCH] netfilter: ipset: replace a strncpy() with strscpy()

Hi, On Wed, 21 Nov 2018, Qian Cai wrote: > To make overflows as obvious as possible and to prevent code from blithely > proceeding with a truncated string. This also has a side-effect to fix a > compilation warning using GCC 8.2.1. > > net/netfilter/ipset/ip_set_core.c: In function

Re: [PATCH nf] netfilter: xt_TEE: fix build failure

Hi Pablo, According to Masahiro Yamada, this is Kconfig bug and he is fixing Kconfig. https://lkml.org/lkml/2018/11/26/291 So that I think this patch will be useless. Could you check it up? Thanks! On Sun, 18 Nov 2018 at 23:39, Taehee Yoo wrote: > > xt_TEE.c needs nf_dup_ipv6.c to support

Re: [PATCH nf] netfilter: nfnetlink_cttimeout: nf_proto_net must be first member of netns_proto_gre

On Wed, Nov 21, 2018 at 01:38:59PM +0100, Florian Westphal wrote: > Can't move timeouts around, it appears conntrack sysctl unregister > assumes net_generic() returns nf_proto_net, so we get crash. > > Expose layout of netns_proto_gre instead. > > Reported-by: kernel test robot > Fixes: