Re: [PATCH nf] netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()

2018-12-03 Thread Pablo Neira Ayuso
On Mon, Nov 26, 2018 at 08:03:30PM +0900, Taehee Yoo wrote: > basechain->stats is rcu protected data. > And write critical section of basechain->stats data is > nft_chain_stats_replace(). > The function is executed in commit phase. so that actually commit_mutex > lock protects that. > Hence

[PATCH nft] parser: bail out on incorrect burst unit

2018-12-03 Thread Pablo Neira Ayuso
Burst can be either bytes or packets, depending on the rate limit unit. # nft add rule x y iif eth0 limit rate 512 kbytes/second burst 5 packets Error: syntax error, unexpected packets, expecting string or bytes add rule x y iif eth0 limit rate 512 kbytes/second burst 5 packets

Re: [PATCH RESEND iptables] include: extend the headers conflict workaround to in6.h

2018-12-03 Thread Pablo Neira Ayuso
On Sun, Dec 02, 2018 at 06:56:34PM +0200, Baruch Siach wrote: > Commit 8d9d7e4b9ef ("include: fix build with kernel headers before 4.2") > introduced a kernel/user headers conflict workaround that allows build > of iptables with kernel headers older than 4.2. This minor extension > allows build

Re: [iptables PATCH] extensions: libipt_realm: Document allowed realm values

2018-12-03 Thread Pablo Neira Ayuso
On Mon, Dec 03, 2018 at 02:52:28PM +0100, Phil Sutter wrote: > Older versions of iptables allowed for negative realm values by accident > (they would be cast to unsigned). While this was clearly a bug, document > the fixed behaviour. Applied, thanks Phil.

[iptables PATCH] extensions: libipt_realm: Document allowed realm values

2018-12-03 Thread Phil Sutter
Older versions of iptables allowed for negative realm values by accident (they would be cast to unsigned). While this was clearly a bug, document the fixed behaviour. Signed-off-by: Phil Sutter --- extensions/libipt_realm.man | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3] netfilter: nf_conntrack_sip: add sip_external_media logic

2018-12-03 Thread Alin Nastac
From: Alin Nastac Allow media streams that are not passing through this router. When enabled, the sip_external_media logic will leave SDP payload untouched when it detects that interface towards INVITEd party is the same with the one towards media endpoint. Signed-off-by: Alin Nastac ---