Re: [RFC][PATCH 2/3] locking: Annotate spin_unlock_wait() users

On Tue, May 24, 2016 at 7:27 AM, Peter Zijlstra wrote: > spin_unlock_wait() has an unintuitive 'feature' in that it doesn't > fully serialize against the spin_unlock() we've waited on. NAK. We don't start adding more of this "after_ctrl_dep" crap. It's completely

Re: [RFC PATCH 0/2] restore original default of nf_conntrack_helper sysctl

On Mon, Jan 23, 2017 at 4:06 PM, Jiri Kosina wrote: > > Considering this being really close to the "userspace breakage" > borderline, I'm CCing Linus as well. For all I know, there may be some security reason why we really don't want the automatic helpers, even if they can be

Re: [PATCH v2] netfilter: nf_ct_helper: warn when not applying default helper assignment

On Tue, Jan 24, 2017 at 2:17 AM, Jiri Kosina wrote: > + if (!helper) { > + if (unlikely(!net->ct.sysctl_auto_assign_helper && > + !net->ct.auto_assign_helper_warned && > + >

Re: [GIT] Networking

On Wed, Oct 5, 2016 at 3:29 PM, Stephen Rothwell wrote: > > I have been carrying the following merge fix patch (for the merge of > the net-next tree with Linus' tree) for a while now which seems to have > got missed: Ugh. It doesn't seem to be a merge error, because that

Re: [GIT] Networking

On Wed, Oct 5, 2016 at 5:52 PM, Stephen Rothwell wrote: > > Except that commit effectively moved that function from > net/netfilter/nf_tables_netdev.c to > include/net/netfilter/nf_tables_ipv4.h while commit c73c24849011 > ("netfilter: nf_tables_netdev: remove redundant

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Mon, Oct 10, 2016 at 6:49 AM, Aaron Conole wrote: > > Okay, I'm looking it over. Sorry for the mess. So as I already answered to Dave, I'm not actually sure that this was the buggy code, or that my patch would make any difference at all. I never got a good reproducer for

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Sun, Oct 9, 2016 at 6:35 PM, Aaron Conole wrote: > > I was just about to build and test something similar: So I haven't actually tested that one, but looking at the code, it really looks very bogus. In fact, that code just looks like crap. It does *not* do a proper "remove

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Sun, Oct 9, 2016 at 7:49 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > There is one *correct* way to remove an entry from a singly linked > list, and it looks like this: > > struct entry **pp, *p; > > pp = > while ((p = *pp) != NULL)

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Mon, Oct 10, 2016 at 9:28 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > So as I already answered to Dave, I'm not actually sure that this was > the buggy code, or that my patch would make any difference at all. My patch does seem to fix things, and in fact th

Re: slab corruption with current -git

On Mon, Oct 10, 2016 at 5:30 PM, David Miller wrote: > > Linus can you add some extra info to that: Sure. I made it a WARN_ON_ONCE(), but then always just printed the pf/hooknum. It's all over the map: reg->pf=2 and reg->hooknum=4 reg->pf=2 and reg->hooknum=2 reg->pf=2

Re: slab corruption with current -git

On Mon, Oct 10, 2016 at 1:24 AM, David Miller wrote: > > So I've been reviewing this patch and it looks fine, but I also want > to figure out what is actually causing the OOPS and I can't spot it > yet. Yeah, I'm not actually sure the old linked list implementation is buggy

Re: slab corruption with current -git

On Wed, Oct 12, 2016 at 11:27 PM, Markus Trippelsdorf wrote: > > Yeah. > > 105 entry->orig_ops = reg; > 106 entry->ops = *reg; > 107 entry->next = NULL; So ipt_register_table() does: ret = nf_register_net_hooks(net, ops,

slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Sun, Oct 9, 2016 at 12:11 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > Anyway, I don't think I can bisect it, but I'll try to narrow it down > a *bit* at least. > > Not doing any more pulls on this unstable base, I've been puttering > around in trying

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Mon, Oct 10, 2016 at 10:39 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > I guess I will have to double-check that the slub corruption is gone > still with that fixed. So I'm not getting any warnings now from SLUB debugging. So the original bug seems to not h

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

On Sun, Oct 9, 2016 at 8:41 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > This COMPLETELY UNTESTED patch tries to fix the nf_hook_entry code to do this. > > I repeat: it's ENTIRELY UNTESTED. Gaah. That patch was subtle garbage. The "ad

Re: [PATCH RFC 25/26] tile: Remove spin_unlock_wait() arch-specific definitions

On Thu, Jun 29, 2017 at 5:01 PM, Paul E. McKenney wrote: > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > and it appears that all callers could do just as well with a lock/unlock > pair. This commit therefore removes the underlying

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney wrote: > > Agreed, and my next step is to look at spin_lock() followed by > spin_is_locked(), not necessarily the same lock. Hmm. Most (all?) "spin_is_locked()" really should be about the same thread that took the lock

WARN_ON() in __nf_hook_entries_try_shrink()

On shutdown I get this (edited down a bit to be more legible): Stopping firewalld - dynamic firewall daemon... NETFILTER_CFG table=nat family=2 entries=55 NETFILTER_CFG table=mangle family=2 entries=40 NETFILTER_CFG table=raw family=2 entries=28 NETFILTER_CFG table=security family=2