RE: linux-next: build warning after merge of the netfilter-next tree

2017-03-20 Thread Reshetova, Elena 

> Hi all,
> 
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
> net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-
> Wunused-variable]
>   unsigned int refcount;
>^
> 
> Introduced by commit

Ups, sorry about this, slipped through. Should I submit a fix or how do you 
want to handle this?

Best Regards,
Elena.

> 
>   b54ab92b84b6 ("netfilter: refcounter conversions")
> 
> --
> Cheers,
> Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/7] net, netfilter refcounter conversions

2017-03-16 Thread Reshetova, Elena 

> On Wed, Mar 15, 2017 at 01:10:38PM +0200, Elena Reshetova wrote:
> > This series, for the netfilter subsystem, replaces atomic_t reference
> > counters with the new refcount_t type and API (see 
> > include/linux/refcount.h).
> > By doing this we prevent intentional or accidental
> > underflows or overflows that can led to use-after-free vulnerabilities.
> >
> > Please take the series to your tree if there are no run-time issues.
> 
> Could you collapse all of your patches into one single? They are all
> part of the same logical change to me.
> 
> >  21 files changed, 85 insertions(+), 75 deletions(-)
> 
> The diffstat is small enough to do what I'm asking.

Sure. The reason why they are separated is that it is easier to review them 
this way IMO and find mistakes (I found many after I split all networking 
patches into one per variable).
But I guess for merge, it is easier to have them collapsed, so I am going to 
send you a new version shortly. 

Best Regards,
Elena.

> 
> Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html