Re: [PATCH nf] netfilter: nat: limit port clash resolution attempts

2018-12-08 Thread Xiaozhou Liu
On Sat, Dec 08, 2018 at 11:07:44AM +0100, Florian Westphal wrote: > Pablo, > > this will unfortunately result in a nf-next merge conflict > due to *rover removal in nf-next. > I can send a patch vs. nf-next instead if you prefer. > > net/netfilter/nf_nat_proto_common.c | 26

[PATCH nf-next] netfilter: nat: remove unnecessary 'else if' branch

2018-12-05 Thread Xiaozhou Liu
Since a pseudo-random starting point is used in finding a port in the default case, that 'else if' branch above is no longer a necessity. So remove it to simplify code. Signed-off-by: Xiaozhou Liu --- net/netfilter/nf_nat_proto_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net

[PATCH] netfilter: update comment about get_unique_tuple()

2018-11-26 Thread Xiaozhou Liu
`__ip_conntrack_confirm' in the comments is confusing to newcomers since it has long been replaced with __nf_conntrack_confirm. Signed-off-by: Xiaozhou Liu --- net/netfilter/nf_nat_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_nat_core.c b/net