Re: [PATCH] build: abandon KERNEL_INCLUDES variable

2018-06-26 Thread Duncan Roe
On Tue, Jun 26, 2018 at 08:21:30AM +0200, Jan Engelhardt wrote: > Since UAPI headers are shipped since commit > ebtables-2.0.10-4-8-gf4bdc80, "-Iinclude" must always be used ever > since. Remove the KERNEL_INCLUDES make variable for good. > > Signed-off-by: Jan Engelhardt > --- > INSTALL

Re: [PATCH] build: abandon KERNEL_INCLUDES variable

2018-06-26 Thread Jan Engelhardt
On Tuesday 2018-06-26 11:03, Máté Eckl wrote: >Isn't that an option to add these includes to CFLAGS variable? So that it would >be less redundant. Yes and no... No, because CFLAGS -- at least in the automake world, which I know ebtables is far from, but let's go with the thought anyway --

Re: [PATCH] build: abandon KERNEL_INCLUDES variable

2018-06-26 Thread Máté Eckl
Hi, Isn't that an option to add these includes to CFLAGS variable? So that it would be less redundant. There is another comment below. Máté On Tue, Jun 26, 2018 at 08:21:30AM +0200, Jan Engelhardt wrote: > Since UAPI headers are shipped since commit > ebtables-2.0.10-4-8-gf4bdc80, "-Iinclude"

Re: [PATCH] build: abandon KERNEL_INCLUDES variable

2018-06-26 Thread Phil Sutter
Hi Jan, On Tue, Jun 26, 2018 at 08:21:30AM +0200, Jan Engelhardt wrote: > Since UAPI headers are shipped since commit > ebtables-2.0.10-4-8-gf4bdc80, "-Iinclude" must always be used ever > since. Remove the KERNEL_INCLUDES make variable for good. > > Signed-off-by: Jan Engelhardt > --- >