Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-28 Thread Jozsef Kadlecsik
On Tue, 28 Mar 2017, Josh Hunt wrote: > > Thinking over it I understand better your approach: replace > > IPSET_ATTR_NETMASK with IPSET_ATTR_NETMASK_MASK completely and keeping > > the former for backward compatibility reasons only. What I propose is > > able to maintain syntax-compatibility in

Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-28 Thread Josh Hunt
On 03/28/2017 01:28 PM, Jozsef Kadlecsik wrote: Hi Josh, On Tue, 28 Mar 2017, Josh Hunt wrote: Overall, I like the feature and the patches. After reviewing I comment only the parts where I believe some modifications are needed. Thanks for the review. I'll go through this and send a v2 in the

Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-28 Thread Jozsef Kadlecsik
Hi Josh, On Tue, 28 Mar 2017, Josh Hunt wrote: > > Overall, I like the feature and the patches. After reviewing I comment > > only the parts where I believe some modifications are needed. > > Thanks for the review. I'll go through this and send a v2 in the next > few days. Thinking over it I u

Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-28 Thread Josh Hunt
On 03/27/2017 02:21 PM, Jozsef Kadlecsik wrote: Hi Josh, Overall, I like the feature and the patches. After reviewing I comment only the parts where I believe some modifications are needed. Jozsef Thanks for the review. I'll go through this and send a v2 in the next few days. Josh -- To u

Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-27 Thread Jozsef Kadlecsik
Hi Josh, Overall, I like the feature and the patches. After reviewing I comment only the parts where I believe some modifications are needed. On Tue, 21 Mar 2017, Josh Hunt wrote: > Extends ipset netmask support to handle both cidr values and full > netmasks. As part of that it now supports wil

Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-24 Thread kbuild test robot
Hi Josh, [auto build test ERROR on nf-next/master] [also build test ERROR on v4.11-rc3 next-20170324] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Josh-Hunt/netfilter-ipset-Extend-netmask-supp

[PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

2017-03-21 Thread Josh Hunt
Extends ipset netmask support to handle both cidr values and full netmasks. As part of that it now supports wildcard masks allowing the user to mask out any bits of an address. This commit provides the infrastructure to specify netmasks of these types for hash sets of both v4 and v6 addressees. Fo