Re: [PATCH 5/5] net/netfilter/nf_conntrack_core: update memory barriers.

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 15:42 +0200, Manfred Spraul wrote: > As explained in commit 51d7d5205d33 > ("powerpc: Add smp_mb() to arch_spin_is_locked()", for some architectures > the ACQUIRE during spin_lock only applies to loading the lock, not to > storing the lock state. > > nf_conntrack_lock() does

[PATCH 5/5] net/netfilter/nf_conntrack_core: update memory barriers.

2016-08-31 Thread Manfred Spraul
As explained in commit 51d7d5205d33 ("powerpc: Add smp_mb() to arch_spin_is_locked()", for some architectures the ACQUIRE during spin_lock only applies to loading the lock, not to storing the lock state. nf_conntrack_lock() does not handle this correctly: /* 1) Acquire the lock */