Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Paul Moore
On Thu, Feb 23, 2017 at 8:59 PM, Florian Westphal wrote: > Richard Guy Briggs wrote: >> > Not following, sorry, are you saying users can/should use -j MARK >> > somehow? >> >> Part of the discussed design and rationale for stripping many of the >> vanishing

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Florian Westphal
Richard Guy Briggs wrote: > > Not following, sorry, are you saying users can/should use -j MARK > > somehow? > > Part of the discussed design and rationale for stripping many of the > vanishing fields is that when setting up netfilter rules to invoke the > AUDIT target, an

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Florian Westphal
Paul Moore wrote: > On Thu, Feb 23, 2017 at 12:35 PM, Richard Guy Briggs wrote: > > I had another idea on how to include the sport and dport and that was to > > use the same identifier for sport/icmptype and also for dport/icmpcode, > > but you've already

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Paul Moore
On Thu, Feb 23, 2017 at 12:35 PM, Richard Guy Briggs wrote: > On 2017-02-23 12:14, Paul Moore wrote: >> On Thu, Feb 23, 2017 at 12:13 PM, Richard Guy Briggs wrote: >> > On 2017-02-23 12:06, Paul Moore wrote: >> >> On Thu, Feb 23, 2017 at 12:04 PM, Richard Guy

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Richard Guy Briggs
On 2017-02-23 12:20, Steve Grubb wrote: > On Wednesday, February 22, 2017 9:50:54 PM EST Richard Guy Briggs wrote: > > Simplify and eliminate flipping in and out of message fields, relying on > > nfmark the way we do for audit_key. > > > > https://github.com/linux-audit/audit-kernel/issues/11 > >

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Steve Grubb
On Wednesday, February 22, 2017 9:50:54 PM EST Richard Guy Briggs wrote: > Simplify and eliminate flipping in and out of message fields, relying on > nfmark the way we do for audit_key. > > https://github.com/linux-audit/audit-kernel/issues/11 > > Signed-off-by: Richard Guy Briggs

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Richard Guy Briggs
On 2017-02-23 18:06, Florian Westphal wrote: > Richard Guy Briggs wrote: > > On 2017-02-23 11:57, Paul Moore wrote: > > > On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs > > > wrote: > > > > On 2017-02-23 06:20, Florian Westphal wrote: > > > >> Richard Guy

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Paul Moore
On Thu, Feb 23, 2017 at 12:13 PM, Richard Guy Briggs wrote: > On 2017-02-23 12:06, Paul Moore wrote: >> On Thu, Feb 23, 2017 at 12:04 PM, Richard Guy Briggs wrote: >> > On 2017-02-23 11:57, Paul Moore wrote: >> >> On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Richard Guy Briggs
On 2017-02-23 12:06, Paul Moore wrote: > On Thu, Feb 23, 2017 at 12:04 PM, Richard Guy Briggs wrote: > > On 2017-02-23 11:57, Paul Moore wrote: > >> On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs > >> wrote: > >> > On 2017-02-23 06:20, Florian Westphal

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Paul Moore
On Thu, Feb 23, 2017 at 12:04 PM, Richard Guy Briggs wrote: > On 2017-02-23 11:57, Paul Moore wrote: >> On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs wrote: >> > On 2017-02-23 06:20, Florian Westphal wrote: >> >> Richard Guy Briggs

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Florian Westphal
Richard Guy Briggs wrote: > On 2017-02-23 11:57, Paul Moore wrote: > > On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs > > wrote: > > > On 2017-02-23 06:20, Florian Westphal wrote: > > >> Richard Guy Briggs wrote: > > >> > Simplify and

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Richard Guy Briggs
On 2017-02-23 11:57, Paul Moore wrote: > On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs wrote: > > On 2017-02-23 06:20, Florian Westphal wrote: > >> Richard Guy Briggs wrote: > >> > Simplify and eliminate flipping in and out of message fields, relying on

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Paul Moore
On Thu, Feb 23, 2017 at 10:51 AM, Richard Guy Briggs wrote: > On 2017-02-23 06:20, Florian Westphal wrote: >> Richard Guy Briggs wrote: >> > Simplify and eliminate flipping in and out of message fields, relying on >> > nfmark >> > the way we do for audit_key.

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-23 Thread Richard Guy Briggs
On 2017-02-23 06:20, Florian Westphal wrote: > Richard Guy Briggs wrote: > > Simplify and eliminate flipping in and out of message fields, relying on > > nfmark > > the way we do for audit_key. > > > > +struct nfpkt_par { > > + int ipv; > > + const void *saddr; > > +

Re: [PATCH V2] audit: normalize NETFILTER_PKT (fwd)

2017-02-23 Thread Richard Guy Briggs
: Thu, 23 Feb 2017 12:43:05 +0800 > From: kbuild test robot <fengguang...@intel.com> > To: kbu...@01.org > Cc: Julia Lawall <julia.law...@lip6.fr> > Subject: Re: [PATCH V2] audit: normalize NETFILTER_PKT > > CC: kbuild-...@01.org > In-Reply-To: > <9504740e9333a0b

Re: [PATCH V2] audit: normalize NETFILTER_PKT (fwd)

2017-02-22 Thread Julia Lawall
-- Date: Thu, 23 Feb 2017 12:43:05 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH V2] audit: normalize NETFILTER_PKT CC: kbuild-...@01.org In-Reply-To: <9504740e9333a0b7074abe0dddfc487aeeae6cff

Re: [PATCH V2] audit: normalize NETFILTER_PKT

2017-02-22 Thread Florian Westphal
Richard Guy Briggs wrote: > Simplify and eliminate flipping in and out of message fields, relying on > nfmark > the way we do for audit_key. > > +struct nfpkt_par { > + int ipv; > + const void *saddr; > + const void *daddr; > + u8 proto; > +}; This is