Re: [PATCH nf] netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()

2018-12-03 Thread Pablo Neira Ayuso
On Mon, Nov 26, 2018 at 08:03:30PM +0900, Taehee Yoo wrote: > basechain->stats is rcu protected data. > And write critical section of basechain->stats data is > nft_chain_stats_replace(). > The function is executed in commit phase. so that actually commit_mutex > lock protects that. > Hence

[PATCH nf] netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()

2018-11-26 Thread Taehee Yoo
basechain->stats is rcu protected data. And write critical section of basechain->stats data is nft_chain_stats_replace(). The function is executed in commit phase. so that actually commit_mutex lock protects that. Hence commit_mutex lockdep should be used for rcu_dereference_protected() in the