On Sat, Nov 17, 2018 at 07:14:57PM +0100, Pablo Neira Ayuso wrote:
> On Sat, Nov 17, 2018 at 09:19:52PM +0900, Xin Long wrote:
> > On Sat, Nov 17, 2018 at 8:15 PM Pablo Neira Ayuso <pa...@netfilter.org>
> > wrote:
> > >
> > > On Fri, Nov 16, 2018 at 06:37:19AM -0800, Simon Horman wrote:
> > > > On Fri, Nov 16, 2018 at 09:10:16AM +0200, Julian Anastasov wrote:
> > > > >
> > > > > Hello,
> > > > >
> > > > > On Thu, 15 Nov 2018, Xin Long wrote:
> > > > >
> > > > > > ip_vs_dst_event is supposed to clean up all dst used in ipvs'
> > > > > > destinations when a net dev is going down. But it works only
> > > > > > when the dst's dev is the same as the dev from the event.
> > > > > >
> > > > > > Now with the same priority but late registration,
> > > > > > ip_vs_dst_notifier is always called later than ipv6_dev_notf
> > > > > > where the dst's dev is set to lo for NETDEV_DOWN event.
> > > > > >
> > > > > > As the dst's dev lo is not the same as the dev from the event
> > > > > > in ip_vs_dst_event, ip_vs_dst_notifier doesn't actually work.
> > > > > > Also as these dst have to wait for dest_trash_timer to clean
> > > > > > them up. It would cause some non-permanent kernel warnings:
> > > > > >
> > > > > > unregister_netdevice: waiting for br0 to become free. Usage count
> > > > > > = 3
> > > > > >
> > > > > > To fix it, call ip_vs_dst_notifier earlier than ipv6_dev_notf
> > > > > > by increasing its priority to ADDRCONF_NOTIFY_PRIORITY + 5.
> > > > > >
> > > > > > Note that for ipv4 route fib_netdev_notifier doesn't set dst's
> > > > > > dev to lo in NETDEV_DOWN event, so this fix is only needed when
> > > > > > IP_VS_IPV6 is defined.
> > > > > >
> > > > > > v1->v2:
> > > > > > - apply it only when CONFIG_IP_VS_IPV6 is defined.
> > > > > >
> > > > > > Fixes: 7a4f0761fce3 ("IPVS: init and cleanup restructuring")
> > > > > > Reported-by: Li Shuang <shu...@redhat.com>
> > > > > > Signed-off-by: Xin Long <lucien....@gmail.com>
> > > > >
> > > > > Acked-by: Julian Anastasov <j...@ssi.bg>
> > > >
> > > > Thanks,
> > > >
> > > > Pablo, could you consider this for nf?
> > > >
> > > > Acked-by: Simon Horman <ho...@verge.net.au>
> > >
> > > Applied, thanks Simon.
> > Hi Pablo,
> >
> > The one you just applied is the v1, I'm afraid you need
> > to revert and apply the v2, which fixed a build error
> > when IPv6 is disabled.
>
> Fixed, thanks!
Thanks Pablo!
