Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-28 Thread Jan Engelhardt
On Saturday 2018-04-28 10:28, Yuri Gribov wrote: >>> AM_CPPFLAGS = -I$(top_srcdir)/include >>>-AM_CFLAGS = -Wall >>>+AM_CFLAGS = -Wall @VISFLAGS@ >> >> Only use @@ in .am files when you must (like, left-hand sides). >> Otherwise, just ${VISFLAGS}. > >Ok, thanks. LDSFLAGS probly have to keep using

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-28 Thread Yuri Gribov
On Sat, Apr 28, 2018 at 8:45 AM, Jan Engelhardt wrote: > > On Saturday 2018-04-28 00:29, Yuri Gribov wrote: >>--- a/Make_global.am >>+++ b/Make_global.am >>@@ -5,4 +5,4 @@ >> LIBVERSION=2:0:2 >> >> AM_CPPFLAGS = -I$(top_srcdir)/include >>-AM_CFLAGS = -Wall >>+AM_CFLAGS = -Wall

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-28 Thread Jan Engelhardt
On Saturday 2018-04-28 00:29, Yuri Gribov wrote: >--- a/Make_global.am >+++ b/Make_global.am >@@ -5,4 +5,4 @@ > LIBVERSION=2:0:2 > > AM_CPPFLAGS = -I$(top_srcdir)/include >-AM_CFLAGS = -Wall >+AM_CFLAGS = -Wall @VISFLAGS@ Only use @@ in .am files when you must (like, left-hand sides).

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Yuri Gribov
On Fri, Apr 27, 2018 at 11:23 PM, Yuri Gribov wrote: > On Fri, Apr 27, 2018 at 9:10 PM, Florian Westphal wrote: >> It doesn't build for me: >> x86_64-pc-linux-gnu/bin/ld: cannot open linker script file ./nfnl.version: >> No such file or directory >> >> I

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Yuri Gribov
On Fri, Apr 27, 2018 at 9:10 PM, Florian Westphal wrote: > It doesn't build for me: > x86_64-pc-linux-gnu/bin/ld: cannot open linker script file ./nfnl.version: No > such file or directory > > I need to move that file to src/. It turned out to be slightly more complicated

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Florian Westphal
Yuri Gribov wrote: > On Fri, Apr 27, 2018 at 8:37 PM, Florian Westphal wrote: > > Yuri Gribov wrote: > >> Would something like this make sense for trunk? > > Yes, I think its a good idea to hide them. > > Ah, great. Let me know if

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Yuri Gribov
On Fri, Apr 27, 2018 at 8:37 PM, Florian Westphal wrote: > Yuri Gribov wrote: >> Would something like this make sense for trunk? > Yes, I think its a good idea to hide them. Ah, great. Let me know if something should be fixed in the patch (in addition to

Re: [RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Florian Westphal
Yuri Gribov wrote: > I've recently tried applying -fvisibility=hidden to libnfnetlink > (draft patch attached) and was able to remove several (supposedly > private) symbols from library interface: > nfnl_set_sequence_tracking > nfnl_unset_sequence_tracking > rtnl_close

[RFC][PATCH] Hide private symbols in libnfnetlink

2018-04-27 Thread Yuri Gribov
Hi all, I've recently tried applying -fvisibility=hidden to libnfnetlink (draft patch attached) and was able to remove several (supposedly private) symbols from library interface: nfnl_set_sequence_tracking nfnl_unset_sequence_tracking rtnl_close rtnl_dump_type rtnl_handler_register