Re: [nft PATCH] libnftables: Simplify nft_run_cmd_from_buffer footprint

2018-06-18 Thread Pablo Neira Ayuso
On Sun, Jun 17, 2018 at 09:22:22AM +0200, Phil Sutter wrote: [...] > First of all, the command buffer passed to nft_run_cmd_from_buffer may > (and should) be const. One should consider it a bug if that function > ever changed it's content. Applied, thanks. -- To unsubscribe from this list: send

Re: [nft PATCH] libnftables: Simplify nft_run_cmd_from_buffer footprint

2018-06-17 Thread Arturo Borrero Gonzalez
On 17 June 2018 at 13:30, Arturo Borrero Gonzalez wrote: > On 17 June 2018 at 09:22, Phil Sutter wrote: >> With libnftables documentation being upstream and one confirmed external >> user (nftlb), time to break the API! >> >> First of all, the command buffer passed to nft_run_cmd_from_buffer may

Re: [nft PATCH] libnftables: Simplify nft_run_cmd_from_buffer footprint

2018-06-17 Thread Arturo Borrero Gonzalez
On 17 June 2018 at 09:22, Phil Sutter wrote: > With libnftables documentation being upstream and one confirmed external > user (nftlb), time to break the API! > > First of all, the command buffer passed to nft_run_cmd_from_buffer may > (and should) be const. One should consider it a bug if that

[nft PATCH] libnftables: Simplify nft_run_cmd_from_buffer footprint

2018-06-17 Thread Phil Sutter
With libnftables documentation being upstream and one confirmed external user (nftlb), time to break the API! First of all, the command buffer passed to nft_run_cmd_from_buffer may (and should) be const. One should consider it a bug if that function ever changed it's content. On the other hand,