Re: [nft PATCH] tests: shell: Extend get element test

2018-10-23 Thread Pablo Neira Ayuso
On Tue, Oct 23, 2018 at 12:33:28PM +0200, Phil Sutter wrote: > On Tue, Oct 23, 2018 at 11:28:28AM +0200, Pablo Neira Ayuso wrote: [...] > > Using current nftables git HEAD plus kernel patch, I'm getting: > > > > # nft get element ip t s '{ 25, 28 }' > > table ip t { > > set s { > >

Re: [nft PATCH] tests: shell: Extend get element test

2018-10-23 Thread Phil Sutter
Hi, On Tue, Oct 23, 2018 at 11:28:28AM +0200, Pablo Neira Ayuso wrote: > On Mon, Oct 22, 2018 at 11:14:32PM +0200, Phil Sutter wrote: > > Hi Pablo, > > > > On Mon, Oct 22, 2018 at 09:45:02PM +0200, Pablo Neira Ayuso wrote: > > [...] > > > > A bit of context illustrating why I think the code

Re: [nft PATCH] tests: shell: Extend get element test

2018-10-23 Thread Pablo Neira Ayuso
On Mon, Oct 22, 2018 at 11:14:32PM +0200, Phil Sutter wrote: > Hi Pablo, > > On Mon, Oct 22, 2018 at 09:45:02PM +0200, Pablo Neira Ayuso wrote: > [...] > > > A bit of context illustrating why I think the code needs more than just > > > "more fixes": AFAIU, for each input element (which may be

Re: [nft PATCH] tests: shell: Extend get element test

2018-10-22 Thread Phil Sutter
Hi Pablo, On Mon, Oct 22, 2018 at 09:45:02PM +0200, Pablo Neira Ayuso wrote: [...] > > A bit of context illustrating why I think the code needs more than just > > "more fixes": AFAIU, for each input element (which may be part of a > > range or not), code asks the kernel for whether the element

Re: [nft PATCH] tests: shell: Extend get element test

2018-10-22 Thread Pablo Neira Ayuso
Hi Phil, On Mon, Oct 22, 2018 at 03:45:09PM +0200, Phil Sutter wrote: > Despite the recent fixes, the test still fails. While trying to address > the remaining issues, I found more potentially problematic inputs so > extend the test by those. Applied, thanks. More comments, see below. > --- >

[nft PATCH] tests: shell: Extend get element test

2018-10-22 Thread Phil Sutter
Despite the recent fixes, the test still fails. While trying to address the remaining issues, I found more potentially problematic inputs so extend the test by those. Signed-off-by: Phil Sutter --- Hi, A bit of context illustrating why I think the code needs more than just "more fixes": AFAIU,