Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

2017-08-15 Thread Pablo Neira Ayuso
On Tue, Aug 15, 2017 at 01:05:04PM +0200, Phil Sutter wrote: > Hi, > > On Tue, Aug 15, 2017 at 12:25:00PM +0200, Pablo Neira Ayuso wrote: > > On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote: > [...] > > > I didn't notice this because I didn't test for kernels without support > > > for

Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

2017-08-15 Thread Phil Sutter
Hi, On Tue, Aug 15, 2017 at 12:25:00PM +0200, Pablo Neira Ayuso wrote: > On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote: [...] > > I didn't notice this because I didn't test for kernels without support > > for transactions. This has been added to nftables in kernel version 3.16 > > ba

Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

2017-08-15 Thread Pablo Neira Ayuso
On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote: > Echo support in nft_mnl_talk() was broken: nft_mnl_talk_cb() passed > cbdata->data as second parameter to netlink_echo_callback() which > expected it to be of type struct netlink_ctx while in fact it was > whatever callers of nft_mnl_ta

[nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

2017-08-14 Thread Phil Sutter
Echo support in nft_mnl_talk() was broken: nft_mnl_talk_cb() passed cbdata->data as second parameter to netlink_echo_callback() which expected it to be of type struct netlink_ctx while in fact it was whatever callers of nft_mnl_talk() passed as callback data (in most cases a NULL pointer). I didn'