Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Eric Dumazet
On Mon, 2016-11-28 at 19:09 +0100, Florian Westphal wrote: > We should prevent OOM killer from running in first place (GFP_NORETRY should > work). Make sure that a vmalloc(8) will succeed, even if few pages need to be swapped out. Otherwise, some scripts using iptables will die while they

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Marcelo Ricardo Leitner
On Mon, Nov 28, 2016 at 07:09:25PM +0100, Florian Westphal wrote: > Neil Horman wrote: > > [ trimming CCs ] > > > On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote: > > > Neil Horman wrote: > > > > I'm not sure I agree with that.

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Florian Westphal
Neil Horman wrote: [ trimming CCs ] > On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote: > > Neil Horman wrote: > > > I'm not sure I agree with that. Generally speaking it seems like the > > > right > > > thing to do, if you want

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Neil Horman
On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote: > Neil Horman wrote: > > I'm not sure I agree with that. Generally speaking it seems like the right > > thing to do, if you want to avoid filling logs with warnings, but this is > > the > > sort of error

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Florian Westphal
Neil Horman wrote: > I'm not sure I agree with that. Generally speaking it seems like the right > thing to do, if you want to avoid filling logs with warnings, but this is the > sort of error that is going to be accompanied by severe service interruption. > I'd rather see

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Neil Horman
On Mon, Nov 28, 2016 at 01:13:12PM -0200, Marcelo Ricardo Leitner wrote: > On Mon, Nov 28, 2016 at 09:39:31AM -0500, Neil Horman wrote: > > On Mon, Nov 28, 2016 at 03:33:40PM +0100, Andrey Konovalov wrote: > > > On Mon, Nov 28, 2016 at 3:13 PM, Neil Horman > > > wrote: > >

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Marcelo Ricardo Leitner
On Mon, Nov 28, 2016 at 09:39:31AM -0500, Neil Horman wrote: > On Mon, Nov 28, 2016 at 03:33:40PM +0100, Andrey Konovalov wrote: > > On Mon, Nov 28, 2016 at 3:13 PM, Neil Horman wrote: > > > On Mon, Nov 28, 2016 at 02:00:19PM +0100, Andrey Konovalov wrote: > > >> Hi! > > >>

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Neil Horman
On Mon, Nov 28, 2016 at 02:00:19PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit d8e435f3ab6fea2ea324dce72b51dd7761747523 (Nov 26). > > A reproducer is attached. > > a.out: vmalloc: allocation failure, allocated

net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

2016-11-28 Thread Andrey Konovalov
Hi! I've got the following error report while running the syzkaller fuzzer. On commit d8e435f3ab6fea2ea324dce72b51dd7761747523 (Nov 26). A reproducer is attached. a.out: vmalloc: allocation failure, allocated 823562240 of 1427091456 bytes, mode:0x24000c2(GFP_KERNEL|__GFP_HIGHMEM) oom_reaper: