Re: netfilter question

On Sun, 2016-11-20 at 09:31 -0800, Eric Dumazet wrote: > Thanks Eric, I will test the patch myself, because I believe we need it > asap ;) Current net-next without Florian patch : lpaa24:~# time for f in `seq 1 2000` ; do iptables -A FORWARD ; done real0m12.856s user0m0.590s sys

Re: netfilter question

On Sun, 2016-11-20 at 12:22 -0500, Eric D wrote: > I'm currently abroad for work and will come back home soon. I will > test the solution and provide feedback to Florian by end of week. > > Thanks for jumping on this quickly. > > Eric > > > On Nov 20, 2016 7:33 AM, "Eric Dumazet"

Re: netfilter question

On Thu, 2016-11-17 at 01:07 +0100, Florian Westphal wrote: > + if (state->mem == NULL) { > + state->mem = __alloc_percpu(PAGE_SIZE, PAGE_SIZE); > + if (!state->mem) > + return false; > + } This will fail on arches where PAGE_SIZE=65536 percpu

Re: netfilter question

Hi Florian, thanks for quick response, will give it a try and get back to you with the outcome of my test. On 2016-11-17 01:07 AM, Florian Westphal wrote: > Eric Dumazet wrote: On Wed, Nov 16, 2016 at 2:22 AM, Eric Desrochers wrote: >

Re: netfilter question

On Thu, 2016-11-17 at 01:07 +0100, Florian Westphal wrote: Seems very nice ! > + > +void xt_percpu_counter_free(struct xt_counters *counters) > +{ > + unsigned long pcnt = counters->pcnt; > + > + if (nr_cpu_ids > 1 && (pcnt & (PAGE_SIZE - 1)) == 0) > + free_percpu((void

Re: netfilter question

Eric Dumazet wrote: > > > On Wed, Nov 16, 2016 at 2:22 AM, Eric Desrochers > > > wrote: > > > > Hi Eric, > > > > > > > > My name is Eric and I'm reaching you today as I found your name in > > > > multiple netfilter kernel commits, and was hoping we

Re: netfilter question

On Wed, 2016-11-16 at 16:02 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Wed, Nov 16, 2016 at 2:22 AM, Eric Desrochers wrote: > > > Hi Eric, > > > > > > My name is Eric and I'm reaching you today as I found your name in > > > multiple