[PATCH v3 2/2] parser_bison: Use __error() to avoid syntax error message duplication

2016-11-16 Thread Elise Lennion
Calls to erec_queue() from yyerror() already have "syntax error" in the body of the message, then __error() must be used. Signed-off-by: Elise Lennion --- v3: Separate changes in different patches src/parser_bison.y | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] erec: Make error messages in nft consistent

2016-11-16 Thread Elise Lennion
On Wed, Nov 16, 2016 at 07:43:20PM -0200, Elise Lennion wrote: > Error messages in nft from parser_bison should state "syntax error" to > keep consistency. A new error type was defined to include this message. > > Signed-off-by: Elise Lennion > --- > include/erec.h

[PATCH v3 1/2] erec: Make error messages in nft consistent

2016-11-16 Thread Elise Lennion
Error messages in nft from parser_bison should state "syntax error" to keep consistency. A new error type was defined to include this message. Signed-off-by: Elise Lennion --- v2: Create new error_record_type instead of modify the message within the error_record

Re: netfilter question

2016-11-16 Thread Florian Westphal
Eric Dumazet wrote: > > > On Wed, Nov 16, 2016 at 2:22 AM, Eric Desrochers > > > wrote: > > > > Hi Eric, > > > > > > > > My name is Eric and I'm reaching you today as I found your name in > > > > multiple netfilter kernel commits, and was hoping we

Re: netfilter question

2016-11-16 Thread Eric Dumazet
On Thu, 2016-11-17 at 01:07 +0100, Florian Westphal wrote: Seems very nice ! > + > +void xt_percpu_counter_free(struct xt_counters *counters) > +{ > + unsigned long pcnt = counters->pcnt; > + > + if (nr_cpu_ids > 1 && (pcnt & (PAGE_SIZE - 1)) == 0) > + free_percpu((void

[nft PATCH 2/3] tests: shell: testcase for deleting many set elements

2016-11-16 Thread Arturo Borrero Gonzalez
From: Arturo Borrero Gonzalez This testcase adds and deletes many elements in a set. We add and delete 65.536 elements in a same batch of netlink messages, (single nft -f run). Signed-off-by: Arturo Borrero Gonzalez ---

[nft PATCH 1/3] tests: shell: testcase for adding many set elements

2016-11-16 Thread Arturo Borrero Gonzalez
From: Arturo Borrero Gonzalez This testcase adds many elements in a set. We add 65.356 elements. Signed-off-by: Arturo Borrero Gonzalez --- tests/shell/testcases/sets/0011add_many_elements_0 | 32 1 file changed, 32 insertions(+)

[nft PATCH 3/3] tests: shell: another testcase for deleting many set elements

2016-11-16 Thread Arturo Borrero Gonzalez
From: Arturo Borrero Gonzalez This testcase adds and deletes many elements in a set. We add and delete 65.536 elements in two different nft -f runs. Signed-off-by: Arturo Borrero Gonzalez --- .../testcases/sets/0013add_delete_many_elements_0 | 48

[PATCH nf 2/2] netfilter: nat: switch to new rhlist interface

2016-11-16 Thread Florian Westphal
I got offlist bug report about failing connections and high cpu usage. This happens because we hit 'elasticity' checks in rhashtable that refuses bucket list exceeding 16 entries. The nat bysrc hash unfortunately needs to insert distinct objects that share same key and are identical (have same

[PATCH nf 0/2] netfilter: nat: fix regressions introduced by rhashtable conversion

2016-11-16 Thread Florian Westphal
These two patches address bugs added when I converted the nat bysource hash to rhashtable. First patch fixes object comparision, second patch converts nat bysource to the rhlist interface, we have to deal with identical source identities (distinct connections sharing same ip/port source pair).

Re: netfilter question

2016-11-16 Thread Eric Dumazet
On Wed, 2016-11-16 at 16:02 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Wed, Nov 16, 2016 at 2:22 AM, Eric Desrochers wrote: > > > Hi Eric, > > > > > > My name is Eric and I'm reaching you today as I found your name in > > > multiple