[PATCH] netfilter: fix spelling mistake: "delimitter" -> "delimiter"

2016-08-18 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_debug message Signed-off-by: Colin Ian King --- net/netfilter/nf_conntrack_ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_ftp.c

[PATCH] netfilter: remove redundant check on ret being non-zero

2017-02-28 Thread Colin King
From: Colin Ian King ret is initialized to zero and if it is set to non-zero in the xt_entry_foreach loop then we exit via the out_free label. Hence the check for ret being non-zero is redundant and can be removed. Detected by CoverityScan, CID#1357132 ("Logically Dead

[PATCH] netfilter: fix indent on in statements

2017-08-15 Thread Colin King
From: Colin Ian King The returns on some if statements are not indented correctly, add in the missing tab. Signed-off-by: Colin Ian King --- net/bridge/netfilter/ebt_ip.c | 4 ++-- net/bridge/netfilter/ebt_ip6.c | 2 +- 2 files changed, 3

[PATCH] netfilter: ebtables: clean up initialization of buf

2017-10-16 Thread Colin King
From: Colin Ian King buf is initialized to buf_start and then set on the next statement to buf_start + offsets[i]. Clean this up to just initialize buf to buf_start + offsets[i] to clean up the clang build warning: "Value stored to 'buf' during its initialization is

[PATCH] netfilter: ip6_tables: remove redundant assignment to e

2017-10-17 Thread Colin King
From: Colin Ian King The assignment to variable e is redundant since the same assignment occurs just a few lines later, hence it can be removed. Cleans up clang warning: warning: Value stored to 'e' is never read Signed-off-by: Colin Ian King

[PATCH][V2] netfilter: remove redundant assignment to e

2017-11-07 Thread Colin King
From: Colin Ian King The assignment to variable e is redundant since the same assignment occurs just a few lines later, hence it can be removed. Cleans up clang warning for arp_tables, ip_tables and ip6_tables: warning: Value stored to 'e' is never read

[PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

2017-12-10 Thread Colin King
From: Colin Ian King The structure nf_conntrack_l4proto_gre4 is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'nf_conntrack_l4proto_gre4' was not declared. Should it be static? Signed-off-by: Colin

[PATCH] netfilter: nf_tables: fix memory leak on error exit return

2018-05-09 Thread Colin King
From: Colin Ian King Currently the -EBUSY error return path is not free'ing resources allocated earlier, leaving a memory leak. Fix this by exiting via the error exit label err5 that performs the necessary resource clean up. Detected by CoverityScan, CID#1432975