Re: [PATCH nf-next] netfilter: fix fallout from xt/nf osf separation

2018-05-17 Thread Pablo Neira Ayuso
On Tue, May 08, 2018 at 10:05:38AM +0200, Florian Westphal wrote:
> Stephen Rothwell says:
>   today's linux-next build (x86_64 allmodconfig) produced this warning:
>   ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
> without #include 
> 
> Fix that up and also move kernel-private struct out of uapi (it was not
> exposed in any released kernel version).
> 
> tested via allmodconfig build + make headers_check.

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH nf-next] netfilter: fix fallout from xt/nf osf separation

2018-05-08 Thread Florian Westphal
Stephen Rothwell says:
  today's linux-next build (x86_64 allmodconfig) produced this warning:
  ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
without #include 

Fix that up and also move kernel-private struct out of uapi (it was not
exposed in any released kernel version).

tested via allmodconfig build + make headers_check.

Reported-by: Stephen Rothwell 
Fixes: bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure 
from xt_osf")
Signed-off-by: Florian Westphal 
---
 include/linux/netfilter/nf_osf.h  | 6 ++
 include/uapi/linux/netfilter/nf_osf.h | 8 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/include/linux/netfilter/nf_osf.h b/include/linux/netfilter/nf_osf.h
index a2b39602e87d..0e114c492fb8 100644
--- a/include/linux/netfilter/nf_osf.h
+++ b/include/linux/netfilter/nf_osf.h
@@ -21,6 +21,12 @@ enum osf_fmatch_states {
FMATCH_OPT_WRONG,
 };
 
+struct nf_osf_finger {
+   struct rcu_head rcu_head;
+   struct list_headfinger_entry;
+   struct nf_osf_user_finger   finger;
+};
+
 bool nf_osf_match(const struct sk_buff *skb, u_int8_t family,
  int hooknum, struct net_device *in, struct net_device *out,
  const struct nf_osf_info *info, struct net *net,
diff --git a/include/uapi/linux/netfilter/nf_osf.h 
b/include/uapi/linux/netfilter/nf_osf.h
index 45376eae31ef..8f2f2f403183 100644
--- a/include/uapi/linux/netfilter/nf_osf.h
+++ b/include/uapi/linux/netfilter/nf_osf.h
@@ -1,6 +1,8 @@
 #ifndef _NF_OSF_H
 #define _NF_OSF_H
 
+#include 
+
 #define MAXGENRELEN32
 
 #define NF_OSF_GENRE   (1 << 0)
@@ -57,12 +59,6 @@ struct nf_osf_user_finger {
struct nf_osf_opt   opt[MAX_IPOPTLEN];
 };
 
-struct nf_osf_finger {
-   struct rcu_head rcu_head;
-   struct list_headfinger_entry;
-   struct nf_osf_user_finger   finger;
-};
-
 struct nf_osf_nlmsg {
struct nf_osf_user_finger   f;
struct iphdrip;
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html