Re: [PATCH nft] configure: don't enable xtables when --without-xtables is passed

2018-04-04 Thread Alexander Dahl 
Hello Florian,

thanks for your quick fix. :-)

> diff --git a/configure.ac b/configure.ac
> index 284bcc502346..eb673d52c6f2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -99,7 +99,7 @@ AM_CONDITIONAL([BUILD_CLI], [test "x$with_cli" != xno])
> 
>  AC_ARG_WITH([xtables], [AS_HELP_STRING([--with-xtables],
>  [Use libxtables for iptables interaction)])],
> - [with_libxtables=yes], [with_libxtables=no])
> + [with_libxtables=$withval], [with_libxtables=no])
>  AS_IF([test "x$with_libxtables" != xno], [
>  PKG_CHECK_MODULES([XTABLES], [xtables >= 1.6.1])
>  AC_DEFINE([HAVE_LIBXTABLES], [1], [0])

Tested-by: Alexander Dahl 

Greets
Alex

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH nft] configure: don't enable xtables when --without-xtables is passed

2018-04-04 Thread Florian Westphal 
AC_ARG_WITH runs this when EITHER --with-foo or --without-foo is given,
so use 'withval'.

After this patch:
./configure -> xtables off
./configure --with-xtables -> xtables on
./configure --without-xtables -> xtables off (was on).

Reported-by: Alexander Dahl 
Signed-off-by: Florian Westphal 
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 284bcc502346..eb673d52c6f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -99,7 +99,7 @@ AM_CONDITIONAL([BUILD_CLI], [test "x$with_cli" != xno])
 
 AC_ARG_WITH([xtables], [AS_HELP_STRING([--with-xtables],
 [Use libxtables for iptables interaction)])],
-   [with_libxtables=yes], [with_libxtables=no])
+   [with_libxtables=$withval], [with_libxtables=no])
 AS_IF([test "x$with_libxtables" != xno], [
 PKG_CHECK_MODULES([XTABLES], [xtables >= 1.6.1])
 AC_DEFINE([HAVE_LIBXTABLES], [1], [0])
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html