Re: [PATCH nft 0/6] rework dependency removal (v2)
On Wed, Feb 14, 2018 at 04:22:23PM +0100, Pablo Neira Ayuso wrote: > Hi, > > This patchset aims to address what Florian reported time ago [1]. This > is skipping removal of protocol key payload expressions at network base > for the netdev, bridge and inet. > > It would better to annotate all redundant expressions and add a later > stage, where we can do smarter simplifications by looking globally at > what we have, instead of just looking at current protocol key expression > and last one that we have annotated in the context structure to perform > removals. But I would prefer to have a fix now upstream then look at > this larger rework later on since it would require to review a bit of > the postprocess code. > > The initial 4 patches in this batch are just cleanup/preparation patches > for patches 5/6 and 6/6. > > There is still a few warning in the tests/py/ infrastructure, some of > them I think need to be fixed, and at least one can remain there to > remind us that we can do better. I'm going to push out this so we start giving it some testing. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH nft 0/6] rework dependency removal (v2)
Hi, This patchset aims to address what Florian reported time ago [1]. This is skipping removal of protocol key payload expressions at network base for the netdev, bridge and inet. It would better to annotate all redundant expressions and add a later stage, where we can do smarter simplifications by looking globally at what we have, instead of just looking at current protocol key expression and last one that we have annotated in the context structure to perform removals. But I would prefer to have a fix now upstream then look at this larger rework later on since it would require to review a bit of the postprocess code. The initial 4 patches in this batch are just cleanup/preparation patches for patches 5/6 and 6/6. There is still a few warning in the tests/py/ infrastructure, some of them I think need to be fixed, and at least one can remain there to remind us that we can do better. Let me know if you have any concern with this. Thanks. [1] https://www.spinics.net/lists/netfilter-devel/msg50078.html Pablo Neira Ayuso (6): src: pass family to payload_dependency_kill() payload: add payload_dependency_release() helper function src: add payload_dependency_exists() src: get rid of __payload_dependency_kill() payload: add payload_may_dependency_kill() netlink_delinearize: add meta_may_dependency_kill() include/payload.h | 7 +-- src/netlink.c | 2 +- src/netlink_delinearize.c | 106 +- src/payload.c | 85 - 4 files changed, 165 insertions(+), 35 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
