Re: linux-next: build warning after merge of the netfilter-next tree

[Florian Westphal]

Geert Uytterhoeven  wrote:
> On Tue, May 8, 2018 at 9:17 AM, Florian Westphal  wrote:
> > Stephen Rothwell  wrote:
> >> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell  
> >> wrote:
> >> >
> >> > After merging the netfilter-next tree, today's linux-next build (x86_64
> >> > allmodconfig) produced this warning:
> >> >
> >> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
> >> > without #include 
> >>
> >> > Introduced by commit
> >> >
> >> >   bfb15f2a95cb ("netfilter: extract Passive OS fingerprint 
> >> > infrastructure from xt_osf")
> >
> > I'll send a fix for this, thanks for reporting.
> 
> +config NF_OSF
> +   tristate 'Passive OS fingerprint infrastructure'
> 
> "There is no help available for this option."
> 
> Is this meant to be a user-visible symbol?

No, its not.  I can send a patch in case you're too busy, let me know.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Geert Uytterhoeven]

Hi Florian,

On Tue, May 8, 2018 at 9:17 AM, Florian Westphal  wrote:
> Stephen Rothwell  wrote:
>> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell  
>> wrote:
>> >
>> > After merging the netfilter-next tree, today's linux-next build (x86_64
>> > allmodconfig) produced this warning:
>> >
>> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
>> > without #include 
>>
>> > Introduced by commit
>> >
>> >   bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure 
>> > from xt_osf")
>
> I'll send a fix for this, thanks for reporting.

+config NF_OSF
+   tristate 'Passive OS fingerprint infrastructure'

"There is no help available for this option."

Is this meant to be a user-visible symbol?
I noticed it is selected by NETFILTER_XT_MATCH_OSF.

Thanks!

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Florian Westphal]

Stephen Rothwell  wrote:
> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell  
> wrote:
> >
> > After merging the netfilter-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
> > without #include 
>
> > Introduced by commit
> > 
> >   bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure 
> > from xt_osf")

I'll send a fix for this, thanks for reporting.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Stephen Rothwell]

Hi all,

On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell  
wrote:
>
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type 
> without #include 
> 
> Introduced by commit
> 
>   bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure 
> from xt_osf")

This warning now occurs after the merge of the net-next tree.
-- 
Cheers,
Stephen Rothwell


pgpVGEKeHgG68.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the netfilter-next tree

[Pablo Neira Ayuso]

Hi Stephen,

On Tue, Jan 02, 2018 at 12:14:51PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the netfilter-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from net/ipv6/af_inet6.c:45:0:
> include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' 
> declared inside parameter list
>   int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
>^

Arnd sent a fix for this, thanks for reporting!

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Stephen Rothwell]

Hi Pablo,

On Thu, 16 Nov 2017 15:18:00 +0100 Pablo Neira Ayuso  
wrote:
>
> The patch is already at davem's tree. It's flying there.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Pablo Neira Ayuso]

On Thu, Nov 16, 2017 at 09:46:17AM +1100, Stephen Rothwell wrote:
> Hi Pablo,
> 
> On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso  
> wrote:
> >
> > On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> > > 
> > > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell 
> > >  wrote:  
> > > >
> > > > After merging the netfilter-next tree, today's linux-next build (powerpc
> > > > ppc64_defconfig) produced this warning:
> > > > 
> > > > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 
> > > > 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> > > >  static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> > > >^
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size 
> > > > result in nla_size")  
> > > 
> > > I assume that this warning will now be in the net-next tree ...  
> > 
> > It's my fault, I'll fix this in my next batch, sorry for the inconvenience.
> 
> This has now made it into Linus' tree :-(

The patch is already at davem's tree. It's flying there.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Stephen Rothwell]

Hi Pablo,

On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso  wrote:
>
> On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> > 
> > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell  
> > wrote:  
> > >
> > > After merging the netfilter-next tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > > 
> > > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 
> > > 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> > >  static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> > >^
> > > 
> > > Introduced by commit
> > > 
> > >   5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size 
> > > result in nla_size")  
> > 
> > I assume that this warning will now be in the net-next tree ...  
> 
> It's my fault, I'll fix this in my next batch, sorry for the inconvenience.

This has now made it into Linus' tree :-(

-- 
Cheers,
Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Pablo Neira Ayuso]

On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> Hi Dave,
> 
> On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell  
> wrote:
> >
> > Hi all,
> > 
> > After merging the netfilter-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 
> > 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> >  static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> >^
> > 
> > Introduced by commit
> > 
> >   5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result 
> > in nla_size")
> 
> I assume that this warning will now be in the net-next tree ...

It's my fault, I'll fix this in my next batch, sorry for the inconvenience.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Stephen Rothwell]

Hi Dave,

On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> After merging the netfilter-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' 
> defined but not used [-Wunused-function]
>  static size_t ctnetlink_proto_size(const struct nf_conn *ct)
>^
> 
> Introduced by commit
> 
>   5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result 
> in nla_size")

I assume that this warning will now be in the net-next tree ...

-- 
Cheers,
Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: build warning after merge of the netfilter-next tree

[Stephen Rothwell]

Hi Elena,

On Mon, 20 Mar 2017 07:00:13 + "Reshetova, Elena" 
 wrote:
>
> > After merging the netfilter-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
> > net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' 
> > [-
> > Wunused-variable]
> >   unsigned int refcount;
> >^
> > 
> > Introduced by commit  
> 
> Ups, sorry about this, slipped through. Should I submit a fix or how do you 
> want to handle this?

That's up to Pablo, but presumably you should send him a followup patch.

-- 
Cheers,
Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: linux-next: build warning after merge of the netfilter-next tree

[Reshetova, Elena]

> Hi all,
> 
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
> net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-
> Wunused-variable]
>   unsigned int refcount;
>^
> 
> Introduced by commit

Ups, sorry about this, slipped through. Should I submit a fix or how do you 
want to handle this?

Best Regards,
Elena.

> 
>   b54ab92b84b6 ("netfilter: refcounter conversions")
> 
> --
> Cheers,
> Stephen Rothwell
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html