Re: [PATCH Netfilter] net: netfilter: Replace printk() with more standardize output format.

2018-03-11 Thread Florian Westphal
Arushi Singhal wrote: > I''ll resend the patch according your suggestions. > > Just for curiosity wanted to ask why not netdev_*(). netfilter is not a network driver. > > > register_net_sysctl(net, "net/netfilter", table); > > > if (!net->ct.event_sysctl_header) { > > > -

Re: [PATCH Netfilter] net: netfilter: Replace printk() with more standardize output format.

2018-03-10 Thread Pablo Neira Ayuso
On Sun, Mar 11, 2018 at 12:09:07AM +0530, Arushi Singhal wrote: > printk() is the raw way to print output and should be avoided. > > For drivers with defined "struct device object", dev_*macro() is > prefer and for "struct netdevice object", netdev_*macro() is prefer over > dev_*macro() to standar